Suppress cppcheck warnings for build-time switch

Add cppcheck-suppress comments for knownConditionTrueFalse warnings related to CROSSPOINT_SHOW_BUTTON_HINTS, which is a build-time configuration switch that may appear as a constant condition during static analysis.
This commit is contained in:
Justin Mitchell
2026-06-08 14:31:55 -04:00
parent 1bc154da8b
commit ed6690c0cc
+4
View File
@@ -143,10 +143,14 @@ bool BaseTheme::showButtonHints() { return CROSSPOINT_SHOW_BUTTON_HINTS; }
// *Impl, which only ever runs when hints are enabled.
void BaseTheme::drawButtonHints(GfxRenderer& renderer, const char* btn1, const char* btn2, const char* btn3,
const char* btn4) const {
// showButtonHints() is a build-time switch (CROSSPOINT_SHOW_BUTTON_HINTS); the
// constant condition is intentional.
// cppcheck-suppress knownConditionTrueFalse
if (!showButtonHints()) return;
drawButtonHintsImpl(renderer, btn1, btn2, btn3, btn4);
}
void BaseTheme::drawSideButtonHints(const GfxRenderer& renderer, const char* topBtn, const char* bottomBtn) const {
// cppcheck-suppress knownConditionTrueFalse
if (!showButtonHints()) return;
drawSideButtonHintsImpl(renderer, topBtn, bottomBtn);
}