From ed6690c0cceb3950c79e4c915746aed0900db31c Mon Sep 17 00:00:00 2001
From: Justin Mitchell <justin@jmitch.com>
Date: Mon, 8 Jun 2026 14:31:55 -0400
Subject: [PATCH] Suppress cppcheck warnings for build-time switch

Add cppcheck-suppress comments for knownConditionTrueFalse warnings related to CROSSPOINT_SHOW_BUTTON_HINTS, which is a build-time configuration switch that may appear as a constant condition during static analysis.
---
 src/components/themes/BaseTheme.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/components/themes/BaseTheme.cpp b/src/components/themes/BaseTheme.cpp
index 41f273bd..24cce04d 100644
--- a/src/components/themes/BaseTheme.cpp
+++ b/src/components/themes/BaseTheme.cpp
@@ -143,10 +143,14 @@ bool BaseTheme::showButtonHints() { return CROSSPOINT_SHOW_BUTTON_HINTS; }
 // *Impl, which only ever runs when hints are enabled.
 void BaseTheme::drawButtonHints(GfxRenderer& renderer, const char* btn1, const char* btn2, const char* btn3,
                                 const char* btn4) const {
+  // showButtonHints() is a build-time switch (CROSSPOINT_SHOW_BUTTON_HINTS); the
+  // constant condition is intentional.
+  // cppcheck-suppress knownConditionTrueFalse
   if (!showButtonHints()) return;
   drawButtonHintsImpl(renderer, btn1, btn2, btn3, btn4);
 }
 void BaseTheme::drawSideButtonHints(const GfxRenderer& renderer, const char* topBtn, const char* bottomBtn) const {
+  // cppcheck-suppress knownConditionTrueFalse
   if (!showButtonHints()) return;
   drawSideButtonHintsImpl(renderer, topBtn, bottomBtn);
 }