cppcheck issue

src/activities/settings/ButtonActionsOverviewActivity.cpp

@@ -31,12 +31,11 @@ constexpr std::array<ButtonRow, 7> kButtonRows = {{
 
 // Find the SettingInfo for a given (button submenu, press kind) pair in the shared settings list.
 const SettingInfo* findEntry(StrId submenu, StrId pressKind) {
-  for (const auto& s : getSettingsList()) {
+  const auto& list = getSettingsList();
-    if (s.submenu == submenu && s.nameId == pressKind && s.category == StrId::STR_CAT_CONTROLS) {
+  auto it = std::find_if(list.begin(), list.end(), [submenu, pressKind](const SettingInfo& s) {
-      return &s;
+    return s.submenu == submenu && s.nameId == pressKind && s.category == StrId::STR_CAT_CONTROLS;
-    }
+  });
-  }
+  return it != list.end() ? &*it : nullptr;
-  return nullptr;
 }
 
 std::string cellValue(StrId submenu, StrId pressKind) {