From 7789a18bb45f01e9948df422f2e3b65230640706 Mon Sep 17 00:00:00 2001
From: jpirnay <jens@pirnay.com>
Date: Mon, 4 May 2026 13:12:19 +0200
Subject: [PATCH] cppcheck issue

---
 .../settings/ButtonActionsOverviewActivity.cpp        | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/activities/settings/ButtonActionsOverviewActivity.cpp b/src/activities/settings/ButtonActionsOverviewActivity.cpp
index 9f0967c0..b281e266 100644
--- a/src/activities/settings/ButtonActionsOverviewActivity.cpp
+++ b/src/activities/settings/ButtonActionsOverviewActivity.cpp
@@ -31,12 +31,11 @@ constexpr std::array<ButtonRow, 7> kButtonRows = {{
 
 // Find the SettingInfo for a given (button submenu, press kind) pair in the shared settings list.
 const SettingInfo* findEntry(StrId submenu, StrId pressKind) {
-  for (const auto& s : getSettingsList()) {
-    if (s.submenu == submenu && s.nameId == pressKind && s.category == StrId::STR_CAT_CONTROLS) {
-      return &s;
-    }
-  }
-  return nullptr;
+  const auto& list = getSettingsList();
+  auto it = std::find_if(list.begin(), list.end(), [submenu, pressKind](const SettingInfo& s) {
+    return s.submenu == submenu && s.nameId == pressKind && s.category == StrId::STR_CAT_CONTROLS;
+  });
+  return it != list.end() ? &*it : nullptr;
 }
 
 std::string cellValue(StrId submenu, StrId pressKind) {