eric/Crosspoint
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: EndOfBookOptions fails to compile

Browse Source 
ActivityManager.h forward-declares Activity but holds
std::unique_ptr<Activity> members. Instantiating that unique_ptr's
destructor requires the complete type, so any TU including
ActivityManager.h without Activity.h fails to compile.

Include Activity.h directly. Adding it to ActivityManager.h instead does
not work: Activity.h depends on HomeMenuItem, which ActivityManager.h
defines.
This commit is contained in:
Uri Tauber
2026-07-19 16:45:42 +03:00
committed by GitHub
parent 9fe4dc5e38
commit 5ba1d5747f
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/activities/reader/EndOfBookOptions.cpp
+4
View File
@@ -6,6 +6,10 @@
#include "CrossPointSettings.h" #include "CrossPointSettings.h"
#include "ReaderUtils.h" #include "ReaderUtils.h"
// ReaderUtils.h pulls in ActivityManager.h, which only forward-declares Activity while holding
// std::unique_ptr<Activity> members. Destroying that unique_ptr needs the complete type, so the
// definition must be visible here.
#include "activities/Activity.h"
#include "components/UITheme.h" #include "components/UITheme.h"
#include "fontIds.h" #include "fontIds.h"
#include "util/ButtonNavigator.h" #include "util/ButtonNavigator.h"