From 5ba1d5747f360dbb839a31b9003073bef902753b Mon Sep 17 00:00:00 2001 From: Uri Tauber Date: Sun, 19 Jul 2026 16:45:42 +0300 Subject: [PATCH] fix: EndOfBookOptions fails to compile ActivityManager.h forward-declares Activity but holds std::unique_ptr members. Instantiating that unique_ptr's destructor requires the complete type, so any TU including ActivityManager.h without Activity.h fails to compile. Include Activity.h directly. Adding it to ActivityManager.h instead does not work: Activity.h depends on HomeMenuItem, which ActivityManager.h defines. --- src/activities/reader/EndOfBookOptions.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/activities/reader/EndOfBookOptions.cpp b/src/activities/reader/EndOfBookOptions.cpp index e76b0e9c..1e6e14db 100644 --- a/src/activities/reader/EndOfBookOptions.cpp +++ b/src/activities/reader/EndOfBookOptions.cpp @@ -6,6 +6,10 @@ #include "CrossPointSettings.h" #include "ReaderUtils.h" +// ReaderUtils.h pulls in ActivityManager.h, which only forward-declares Activity while holding +// std::unique_ptr members. Destroying that unique_ptr needs the complete type, so the +// definition must be visible here. +#include "activities/Activity.h" #include "components/UITheme.h" #include "fontIds.h" #include "util/ButtonNavigator.h"