Zach Nelson
6f7f4c592a
## Summary Relative includes can hide inappropriate dependency relationships. In this case, I found that lib/KOReaderSync/KOReaderCredentialStore.cpp was dependent on src/JsonSettingsIO.h -- a lib -> app dependency, the opposite direction dependencies should flow in this project. This change replaces all relative includes with root-relative includes, and corrects the KOReaderCredentialStore dependency by moving its JSON settings serialization local to the KOReaderSync library. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**PARTIALLY**_
70 lines
2.4 KiB
C++
70 lines
2.4 KiB
C++
#pragma once
|
|
#include <cstdint>
|
|
#include <string>
|
|
|
|
// Document matching method for KOReader sync
|
|
enum class DocumentMatchMethod : uint8_t {
|
|
FILENAME = 0, // Match by filename (simpler, works across different file sources)
|
|
BINARY = 1, // Match by partial MD5 of file content (more accurate, but files must be identical)
|
|
};
|
|
|
|
/**
|
|
* Singleton class for storing KOReader sync credentials on the SD card.
|
|
* Passwords are XOR-obfuscated with the device's unique hardware MAC address
|
|
* and base64-encoded before writing to JSON (not cryptographically secure,
|
|
* but prevents casual reading and ties credentials to the specific device).
|
|
*/
|
|
class KOReaderCredentialStore {
|
|
private:
|
|
static KOReaderCredentialStore instance;
|
|
std::string username;
|
|
std::string password;
|
|
std::string serverUrl; // Custom sync server URL (empty = default)
|
|
DocumentMatchMethod matchMethod = DocumentMatchMethod::FILENAME; // Default to filename for compatibility
|
|
|
|
// Private constructor for singleton
|
|
KOReaderCredentialStore() = default;
|
|
|
|
bool loadFromBinaryFile();
|
|
|
|
public:
|
|
// Delete copy constructor and assignment
|
|
KOReaderCredentialStore(const KOReaderCredentialStore&) = delete;
|
|
KOReaderCredentialStore& operator=(const KOReaderCredentialStore&) = delete;
|
|
|
|
// Get singleton instance
|
|
static KOReaderCredentialStore& getInstance() { return instance; }
|
|
|
|
// Save/load from SD card
|
|
bool saveToFile() const;
|
|
bool loadFromFile();
|
|
|
|
// Credential management
|
|
void setCredentials(const std::string& user, const std::string& pass);
|
|
const std::string& getUsername() const { return username; }
|
|
const std::string& getPassword() const { return password; }
|
|
|
|
// Get MD5 hash of password for API authentication
|
|
std::string getMd5Password() const;
|
|
|
|
// Check if credentials are set
|
|
bool hasCredentials() const;
|
|
|
|
// Clear credentials
|
|
void clearCredentials();
|
|
|
|
// Server URL management
|
|
void setServerUrl(const std::string& url);
|
|
const std::string& getServerUrl() const { return serverUrl; }
|
|
|
|
// Get base URL for API calls (with http:// normalization if no protocol, falls back to default)
|
|
std::string getBaseUrl() const;
|
|
|
|
// Document matching method
|
|
void setMatchMethod(DocumentMatchMethod method);
|
|
DocumentMatchMethod getMatchMethod() const { return matchMethod; }
|
|
};
|
|
|
|
// Helper macro to access credential store
|
|
#define KOREADER_STORE KOReaderCredentialStore::getInstance()
|