## Summary Relative includes can hide inappropriate dependency relationships. In this case, I found that lib/KOReaderSync/KOReaderCredentialStore.cpp was dependent on src/JsonSettingsIO.h -- a lib -> app dependency, the opposite direction dependencies should flow in this project. This change replaces all relative includes with root-relative includes, and corrects the KOReaderCredentialStore dependency by moving its JSON settings serialization local to the KOReaderSync library. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**PARTIALLY**_
32 lines
1016 B
C++
32 lines
1016 B
C++
#pragma once
|
|
|
|
class CrossPointSettings;
|
|
class CrossPointState;
|
|
class WifiCredentialStore;
|
|
class RecentBooksStore;
|
|
class OpdsServerStore;
|
|
|
|
namespace JsonSettingsIO {
|
|
|
|
// CrossPointSettings
|
|
bool saveSettings(const CrossPointSettings& s, const char* path);
|
|
bool loadSettings(CrossPointSettings& s, const char* json, bool* needsResave = nullptr);
|
|
|
|
// CrossPointState
|
|
bool saveState(const CrossPointState& s, const char* path);
|
|
bool loadState(CrossPointState& s, const char* json);
|
|
|
|
// WifiCredentialStore
|
|
bool saveWifi(const WifiCredentialStore& store, const char* path);
|
|
bool loadWifi(WifiCredentialStore& store, const char* json, bool* needsResave = nullptr);
|
|
|
|
// RecentBooksStore
|
|
bool saveRecentBooks(const RecentBooksStore& store, const char* path);
|
|
bool loadRecentBooks(RecentBooksStore& store, const char* json);
|
|
|
|
// OpdsServerStore
|
|
bool saveOpds(const OpdsServerStore& store, const char* path);
|
|
bool loadOpds(OpdsServerStore& store, const char* json, bool* needsResave = nullptr);
|
|
|
|
} // namespace JsonSettingsIO
|