From f66220a2451ab382be95b8aff4a4e47b4a9977e5 Mon Sep 17 00:00:00 2001 From: Ankit Date: Wed, 17 Jun 2026 19:02:36 +0530 Subject: [PATCH] fix: enable Shift key for URL keyboard input (#2178) (#2357) --- src/activities/util/KeyboardEntryActivity.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/activities/util/KeyboardEntryActivity.cpp b/src/activities/util/KeyboardEntryActivity.cpp index 7e5e1a7e..ec509a2a 100644 --- a/src/activities/util/KeyboardEntryActivity.cpp +++ b/src/activities/util/KeyboardEntryActivity.cpp @@ -99,7 +99,9 @@ bool KeyboardEntryActivity::handleKeyPress() { case SpecialKeyType::Shift: delPressCount = 0; hintVisible = false; - if (urlMode || inputType == InputType::Url) return true; + // Shift is meaningless in the URL-snippet panel and the symbol layout, but + // must work for the URL letter layout so uppercase letters can be entered (#2178). + if (urlMode) return true; if (symMode) return true; shiftState = (shiftState + 1) % 2; return true; @@ -675,8 +677,8 @@ void KeyboardEntryActivity::render(RenderLock&&) { const char* label; }; const BottomKeyInfo bottomKeys[BOTTOM_KEY_COUNT] = { - {(symMode || urlMode || inputType == InputType::Url) ? KeyboardKeyType::Disabled : KeyboardKeyType::Shift, - (symMode || urlMode || inputType == InputType::Url) ? shiftString[0] : shiftString[shiftState]}, + {(symMode || urlMode) ? KeyboardKeyType::Disabled : KeyboardKeyType::Shift, + (symMode || urlMode) ? shiftString[0] : shiftString[shiftState]}, {KeyboardKeyType::Mode, urlMode ? "abc" : (symMode ? "abc" : "#@!")}, {inputType == InputType::Url ? KeyboardKeyType::Mode : KeyboardKeyType::Space, inputType == InputType::Url ? "URL" : nullptr},