Merge pull request #143 from jpirnay/fix-stalebuttons

fix: Refactor / remove duplicate / stale button treatments

src/ButtonEventManager.cpp

@@ -33,6 +33,13 @@ void ButtonEventManager::pushEvent(const Button button, const PressType type) {
   eventTail = next;
 }
 
+void ButtonEventManager::pushEventFront(const Button button, const PressType type) {
+  const int prev = (eventHead - 1 + EVENT_BUF) % EVENT_BUF;
+  if (prev == eventTail) return;  // buffer full
+  eventHead = prev;
+  eventBuf[eventHead] = {button, type};
+}
+
 bool ButtonEventManager::consumeEvent(ButtonEvent& out) {
   if (eventHead == eventTail) return false;
   out = eventBuf[eventHead];

src/ButtonEventManager.h

@@ -34,7 +34,7 @@ class ButtonEventManager {
   };
 
   // Timing constants (milliseconds)
-  static constexpr unsigned long LONG_PRESS_MS = 600;
+  static constexpr unsigned long LONG_PRESS_MS = 1000;
   static constexpr unsigned long DOUBLE_WINDOW_MS = 300;
 
   explicit ButtonEventManager(MappedInputManager& input) : input(input) {}
@@ -49,6 +49,10 @@ class ButtonEventManager {
   // Reset all per-button FSMs. Call on activity transitions to prevent bleed-through.
   void drain();
 
+  // Preserve a default event for activity processing after main loop dispatch.
+  // This is used when the configured action is BTN_DEFAULT.
+  void pushEventFront(Button button, PressType type);
+
   // Returns true if a double-click action is configured for this button.
   // ButtonEventManager queries CrossPointSettings internally.
   static bool hasDoubleAction(Button button);

src/CrossPointSettings.cpp

@@ -58,6 +58,11 @@ void applyLegacyFrontButtonLayout(CrossPointSettings& settings) {
   }
 }
 
+void enforceFixedShortActions(CrossPointSettings& settings) {
+  settings.btnShortBack = static_cast<uint8_t>(CrossPointSettings::BUTTON_ACTION::BTN_DEFAULT);
+  settings.btnShortConfirm = static_cast<uint8_t>(CrossPointSettings::BUTTON_ACTION::BTN_DEFAULT);
+}
+
 }  // namespace
 
 void CrossPointSettings::validateFrontButtonMapping(CrossPointSettings& settings) {
@@ -88,13 +93,16 @@ bool CrossPointSettings::loadFromFile() {
     if (!json.isEmpty()) {
       bool resave = false;
       bool result = JsonSettingsIO::loadSettings(*this, json.c_str(), &resave);
-      if (result && resave) {
+      if (result) {
+        enforceFixedShortActions(*this);
+        if (resave) {
           if (saveToFile()) {
             LOG_DBG("CPS", "Resaved settings to update format");
           } else {
             LOG_ERR("CPS", "Failed to resave settings after format update");
           }
         }
+      }
       return result;
     }
   }
@@ -102,6 +110,7 @@ bool CrossPointSettings::loadFromFile() {
   // Fall back to binary migration
   if (Storage.exists(SETTINGS_FILE_BIN)) {
     if (loadFromBinaryFile()) {
+      enforceFixedShortActions(*this);
       if (saveToFile()) {
         Storage.rename(SETTINGS_FILE_BIN, SETTINGS_FILE_BAK);
         LOG_DBG("CPS", "Migrated settings.bin to settings.json");

src/SettingsList.h

@@ -144,8 +144,8 @@ inline const std::vector<SettingInfo> list = {
       StrId::STR_BTN_ACT_KOREADER_SYNC
 
     // Back button: short=exit reader, double=ignore, long=go home
-    SettingInfo::Enum(StrId::STR_BTN_SHORT_PRESS, &CrossPointSettings::btnShortBack,
+    SettingInfo::Enum(StrId::STR_BTN_SHORT_PRESS, &CrossPointSettings::btnShortBack, {StrId::STR_BTN_DEF_EXIT_READER},
-                      {StrId::STR_BTN_DEF_EXIT_READER, BTN_ACT_OPTIONS}, "btnShortBack", StrId::STR_CAT_CONTROLS)
+                      "btnShortBack", StrId::STR_CAT_CONTROLS)
         .withSubcategory(StrId::STR_MENU_BTN_ACTIONS)
         .withSubmenu(StrId::STR_BTN_BACK),
     SettingInfo::Enum(StrId::STR_BTN_DOUBLE_PRESS, &CrossPointSettings::btnDoubleBack,
@@ -156,7 +156,7 @@ inline const std::vector<SettingInfo> list = {
         .withSubmenu(StrId::STR_BTN_BACK),
     // Confirm button: short=reader menu, double=ignore, long=KOReader sync
     SettingInfo::Enum(StrId::STR_BTN_SHORT_PRESS, &CrossPointSettings::btnShortConfirm,
-                      {StrId::STR_BTN_DEF_READER_MENU, BTN_ACT_OPTIONS}, "btnShortConfirm", StrId::STR_CAT_CONTROLS)
+                      {StrId::STR_BTN_DEF_READER_MENU}, "btnShortConfirm", StrId::STR_CAT_CONTROLS)
         .withSubmenu(StrId::STR_BTN_CONFIRM),
     SettingInfo::Enum(StrId::STR_BTN_DOUBLE_PRESS, &CrossPointSettings::btnDoubleConfirm,
                       {StrId::STR_BTN_DEF_IGNORE, BTN_ACT_OPTIONS}, "btnDoubleConfirm", StrId::STR_CAT_CONTROLS)

src/activities/home/FileBrowserActivity.cpp

@@ -16,10 +16,6 @@
 #include "components/UITheme.h"
 #include "fontIds.h"
 
-namespace {
-constexpr unsigned long GO_HOME_MS = 1000;
-}  // namespace
-
 void sortFileList(std::vector<std::string>& strs) {
   std::sort(begin(strs), end(strs), [](const std::string& str1, const std::string& str2) {
     // Directories first
@@ -141,14 +137,14 @@ void FileBrowserActivity::clearFileMetadata(const std::string& fullPath) {
 void FileBrowserActivity::loop() {
   const int pageItems = UITheme::getInstance().getNumberOfItemsPerPage(renderer, true, false, true, false);
 
-  // Long press BACK always navigates to home
+  ButtonEventManager::ButtonEvent ev;
-  if (mappedInput.isPressed(MappedInputManager::Button::Back) && mappedInput.getHeldTime() >= GO_HOME_MS) {
+  while (buttonEvents.consumeEvent(ev)) {
+    if (ev.button == MappedInputManager::Button::Back) {
+      if (ev.type == ButtonEventManager::PressType::Long) {
         onGoHome();
         return;
       }
-
+      if (ev.type == ButtonEventManager::PressType::Short) {
-  // Short press BACK goes up one directory (if not root) or home (at root)
-  if (mappedInput.wasReleased(MappedInputManager::Button::Back) && mappedInput.getHeldTime() < GO_HOME_MS) {
         if (basepath != "/") {
           const std::string oldPath = basepath;
           basepath.replace(basepath.find_last_of('/'), std::string::npos, "");
@@ -164,9 +160,9 @@ void FileBrowserActivity::loop() {
         }
         return;
       }
+    }
 
-  // Confirm short press opens selected entry; long press does nothing
+    if (ev.button == MappedInputManager::Button::Confirm && ev.type == ButtonEventManager::PressType::Short) {
-  if (mappedInput.wasReleased(MappedInputManager::Button::Confirm) && mappedInput.getHeldTime() < GO_HOME_MS) {
       if (files.empty()) return;
 
       const std::string& entry = files[selectorIndex];
@@ -191,9 +187,8 @@ void FileBrowserActivity::loop() {
       return;
     }
 
-  // Left short press does nothing; long press deletes selected file after confirmation
+    if (ev.button == MappedInputManager::Button::Left && ev.type == ButtonEventManager::PressType::Long) {
-  if (mappedInput.wasReleased(MappedInputManager::Button::Left)) {
+      if (files.empty()) {
-    if (mappedInput.getHeldTime() < GO_HOME_MS || files.empty()) {
         return;
       }
 
@@ -234,8 +229,7 @@ void FileBrowserActivity::loop() {
       return;
     }
 
-  // Right opens the info page for epub files
+    if (ev.button == MappedInputManager::Button::Right && ev.type == ButtonEventManager::PressType::Short) {
-  if (mappedInput.wasReleased(MappedInputManager::Button::Right)) {
       if (files.empty()) return;
       const std::string& entry = files[selectorIndex];
       if (entry.back() != '/' && (FsHelpers::hasEpubExtension(entry) || FsHelpers::hasXtcExtension(entry))) {
@@ -246,6 +240,7 @@ void FileBrowserActivity::loop() {
       }
       return;
     }
+  }
 
   // Up/Down side buttons navigate the list
   const int listSize = static_cast<int>(files.size());

src/activities/reader/EpubReaderActivity.cpp

@@ -219,12 +219,14 @@ void EpubReaderActivity::loop() {
   }
 
   if (inputDrainGuard.shouldDrain(mappedInput)) {
+    buttonEvents.drain();
     return;
   }
 
   if (automaticPageTurnActive) {
     if (mappedInput.wasReleased(MappedInputManager::Button::Confirm) ||
         mappedInput.wasReleased(MappedInputManager::Button::Back)) {
+      buttonEvents.drain();
       automaticPageTurnActive = false;
       // updates chapter title space to indicate page turn disabled
       requestUpdate();
@@ -248,59 +250,30 @@ void EpubReaderActivity::loop() {
     }
   }
 
-  // Long press CONFIRM (1s+) goes directly to KOReader sync when credentials are configured.
+  bool delayedPrevTurn = false;
-  // We intentionally keep long-press on the richer compare flow so advanced
+  bool delayedNextTurn = false;
-  // conflict-resolution behavior stays available even after simplifying menu UX.
+  using BA = CrossPointSettings::BUTTON_ACTION;
-  // Without credentials, fall through to the regular menu on release.
+
-  if (mappedInput.isPressed(MappedInputManager::Button::Confirm) &&
+  ButtonEventManager::ButtonEvent ev;
-      mappedInput.getHeldTime() >= ReaderUtils::GO_HOME_MS && KOREADER_STORE.hasCredentials()) {
+  while (buttonEvents.consumeEvent(ev)) {
+    if (ev.button == MappedInputManager::Button::Confirm) {
+      if (ev.type == ButtonEventManager::PressType::Long && KOREADER_STORE.hasCredentials()) {
         launchKOReaderSync(SyncLaunchMode::COMPARE);
         return;
       }
-
+      if (ev.type == ButtonEventManager::PressType::Short) {
-  // Short press CONFIRM enters reader menu activity.
+        openReaderMenu();
-  if (mappedInput.wasReleased(MappedInputManager::Button::Confirm) &&
+        return;
-      mappedInput.getHeldTime() < ReaderUtils::GO_HOME_MS) {
-    const int currentPage = section ? section->currentPage + 1 : 0;
-    const int totalPages = section ? section->pageCount : 0;
-    float bookProgress = 0.0f;
-    if (epub->getBookSize() > 0 && section && section->pageCount > 0) {
-      const float chapterProgress = static_cast<float>(section->currentPage) / static_cast<float>(section->pageCount);
-      bookProgress = epub->calculateProgress(currentSpineIndex, chapterProgress) * 100.0f;
       }
-    const int bookProgressPercent = clampPercent(static_cast<int>(bookProgress + 0.5f));
-    const bool isCurrentPageStarred = section && bookmarkStore.has(static_cast<uint16_t>(currentSpineIndex),
-                                                                   static_cast<uint16_t>(section->currentPage));
-    ReaderUtils::enforceExitFullRefresh(renderer);
-    startActivityForResult(std::make_unique<EpubReaderMenuActivity>(
-                               renderer, mappedInput, epub->getTitle(), currentPage, totalPages, bookProgressPercent,
-                               SETTINGS.orientation, !currentPageFootnotes.empty(), bookEmbeddedStyleOverride,
-                               bookImageRenderingOverride, bookFontFamilyOverride, bookFontSizeOverride,
-                               SETTINGS.textDarkness, !bookmarkStore.isEmpty(), isCurrentPageStarred),
-                           [this](const ActivityResult& result) {
-                             // Always apply orientation/darkness change even if the menu was cancelled
-                             const auto& menu = std::get<MenuResult>(result.data);
-                             applyOrientation(menu.orientation);
-                             applyTextDarkness(menu.textDarkness);
-                             toggleAutoPageTurn(menu.pageTurnOption);
-                             applyBookReaderOverrides(menu.embeddedStyleOverride, menu.imageRenderingOverride,
-                                                      menu.fontFamilyOverride, menu.fontSizeOverride);
-                             if (!result.isCancelled) {
-                               onReaderMenuConfirm(static_cast<EpubReaderMenuActivity::MenuAction>(menu.action));
-                             }
-                           });
     }
 
-  // Long press BACK (1s+) goes to home screen
+    if (ev.button == MappedInputManager::Button::Back) {
-  if (mappedInput.isPressed(MappedInputManager::Button::Back) && mappedInput.getHeldTime() >= ReaderUtils::GO_HOME_MS) {
+      if (ev.type == ButtonEventManager::PressType::Long) {
         ReaderUtils::enforceExitFullRefresh(renderer);
         onGoHome();
         return;
       }
-
+      if (ev.type == ButtonEventManager::PressType::Short) {
-  // Short press BACK returns to the calling activity (or restores position if viewing footnote)
-  if (mappedInput.wasReleased(MappedInputManager::Button::Back) &&
-      mappedInput.getHeldTime() < ReaderUtils::GO_HOME_MS) {
         if (footnoteDepth > 0) {
           restoreSavedPosition();
           return;
@@ -309,8 +282,34 @@ void EpubReaderActivity::loop() {
         finish();
         return;
       }
+    }
+
+    if (ev.type == ButtonEventManager::PressType::Short) {
+      if ((ev.button == MappedInputManager::Button::PageBack && SETTINGS.btnShortPageBack == BA::BTN_DEFAULT &&
+           ButtonEventManager::hasDoubleAction(MappedInputManager::Button::PageBack)) ||
+          (ev.button == MappedInputManager::Button::Left && SETTINGS.btnShortLeft == BA::BTN_DEFAULT &&
+           ButtonEventManager::hasDoubleAction(MappedInputManager::Button::Left))) {
+        delayedPrevTurn = true;
+        continue;
+      }
+      if ((ev.button == MappedInputManager::Button::PageForward && SETTINGS.btnShortPageForward == BA::BTN_DEFAULT &&
+           ButtonEventManager::hasDoubleAction(MappedInputManager::Button::PageForward)) ||
+          (ev.button == MappedInputManager::Button::Right && SETTINGS.btnShortRight == BA::BTN_DEFAULT &&
+           ButtonEventManager::hasDoubleAction(MappedInputManager::Button::Right))) {
+        delayedNextTurn = true;
+        continue;
+      }
+    }
+  }
 
   auto [prevTriggered, nextTriggered] = ReaderUtils::detectPageTurn(mappedInput);
+  if (!prevTriggered && !nextTriggered) {
+    if (!delayedPrevTurn && !delayedNextTurn) {
+      return;
+    }
+    prevTriggered = delayedPrevTurn;
+    nextTriggered = delayedNextTurn;
+  }
   if (!prevTriggered && !nextTriggered) {
     return;
   }
@@ -327,65 +326,6 @@ void EpubReaderActivity::loop() {
     return;
   }
 
-  const bool skipChapter = mappedInput.getHeldTime() > skipChapterMs;
-
-  // Chapter skip navigates by TOC entries, not spine boundaries.
-  // Spine items without their own TOC entry inherit the previous spine's tocIndex
-  // (see BookMetadataCache), so they're treated as continuations of the last chapter.
-  // At the boundaries: skipping forward past the last TOC entry jumps to end-of-book
-  // (clamped in render()); skipping backward before the first TOC entry jumps to the
-  // spine before the current chapter's first spine (clamped to 0 in render()).
-  if (skipChapter) {
-    lastPageTurnTime = millis();
-    {
-      RenderLock lock(*this);
-
-      if (section && section->pageCount > 0) {
-        const int curTocIndex = section->getTocIndexForPage(section->currentPage);
-        const int nextTocIndex = nextTriggered ? curTocIndex + 1 : curTocIndex - 1;
-
-        if (curTocIndex < 0) {
-          // No TOC entry for this spine, fall back to spine-level skip
-          nextPageNumber = 0;
-          currentSpineIndex = nextTriggered ? currentSpineIndex + 1 : currentSpineIndex - 1;
-          section.reset();
-        } else if (nextTocIndex >= 0 && nextTocIndex < epub->getTocItemsCount()) {
-          const int newSpineIndex = epub->getSpineIndexForTocIndex(nextTocIndex);
-
-          if (newSpineIndex == currentSpineIndex) {
-            if (const auto resolvedPage = section->getPageForTocIndex(nextTocIndex)) {
-              section->currentPage = *resolvedPage;
-            } else {
-              LOG_DBG("ERS", "No page boundary for TOC %d in spine %d, staying on current page", nextTocIndex,
-                      currentSpineIndex);
-            }
-          } else {
-            pendingTocIndex = nextTocIndex;
-            nextPageNumber = 0;
-            currentSpineIndex = newSpineIndex;
-            section.reset();
-          }
-        } else if (nextTriggered) {
-          // Beyond last TOC entry, go to end of book
-          nextPageNumber = 0;
-          currentSpineIndex = epub->getSpineItemsCount();
-          section.reset();
-        } else {
-          // Before first TOC entry, skip to spine before the current chapter
-          nextPageNumber = 0;
-          currentSpineIndex = epub->getTocItem(curTocIndex).spineIndex - 1;
-          section.reset();
-        }
-      } else {
-        nextPageNumber = 0;
-        currentSpineIndex = nextTriggered ? currentSpineIndex + 1 : currentSpineIndex - 1;
-        section.reset();
-      }
-    }
-    requestUpdate();
-    return;
-  }
-
   // No current section, attempt to rerender the book
   if (!section) {
     requestUpdate();
@@ -1774,6 +1714,36 @@ bool EpubReaderActivity::drawCurrentPageToBuffer(const std::string& filePath, Gf
   return true;
 }
 
+void EpubReaderActivity::openReaderMenu() {
+  const int currentPage = section ? section->currentPage + 1 : 0;
+  const int totalPages = section ? section->pageCount : 0;
+  float bookProgress = 0.0f;
+  if (epub->getBookSize() > 0 && section && section->pageCount > 0) {
+    const float chapterProgress = static_cast<float>(section->currentPage) / static_cast<float>(section->pageCount);
+    bookProgress = epub->calculateProgress(currentSpineIndex, chapterProgress) * 100.0f;
+  }
+  const int bookProgressPercent = clampPercent(static_cast<int>(bookProgress + 0.5f));
+  const bool isCurrentPageStarred = section && bookmarkStore.has(static_cast<uint16_t>(currentSpineIndex),
+                                                                 static_cast<uint16_t>(section->currentPage));
+  ReaderUtils::enforceExitFullRefresh(renderer);
+  startActivityForResult(
+      std::make_unique<EpubReaderMenuActivity>(
+          renderer, mappedInput, epub->getTitle(), currentPage, totalPages, bookProgressPercent, SETTINGS.orientation,
+          !currentPageFootnotes.empty(), bookEmbeddedStyleOverride, bookImageRenderingOverride, bookFontFamilyOverride,
+          bookFontSizeOverride, SETTINGS.textDarkness, !bookmarkStore.isEmpty(), isCurrentPageStarred),
+      [this](const ActivityResult& result) {
+        const auto& menu = std::get<MenuResult>(result.data);
+        applyOrientation(menu.orientation);
+        applyTextDarkness(menu.textDarkness);
+        toggleAutoPageTurn(menu.pageTurnOption);
+        applyBookReaderOverrides(menu.embeddedStyleOverride, menu.imageRenderingOverride, menu.fontFamilyOverride,
+                                 menu.fontSizeOverride);
+        if (!result.isCancelled) {
+          onReaderMenuConfirm(static_cast<EpubReaderMenuActivity::MenuAction>(menu.action));
+        }
+      });
+}
+
 void EpubReaderActivity::onButtonAction(const CrossPointSettings::BUTTON_ACTION action) {
   using BA = CrossPointSettings::BUTTON_ACTION;
   switch (action) {
@@ -1892,35 +1862,7 @@ void EpubReaderActivity::onButtonAction(const CrossPointSettings::BUTTON_ACTION
       break;
     case BA::BTN_READER_MENU:
       if (epub) {
-        const int currentPage = section ? section->currentPage + 1 : 0;
+        openReaderMenu();
-        const int totalPages = section ? section->pageCount : 0;
-        float bookProgress = 0.0f;
-        if (epub->getBookSize() > 0 && section && section->pageCount > 0) {
-          const float chapterProgress =
-              static_cast<float>(section->currentPage) / static_cast<float>(section->pageCount);
-          bookProgress = epub->calculateProgress(currentSpineIndex, chapterProgress) * 100.0f;
-        }
-        const int bookProgressPercent = clampPercent(static_cast<int>(bookProgress + 0.5f));
-        const bool isCurrentPageStarred = section && bookmarkStore.has(static_cast<uint16_t>(currentSpineIndex),
-                                                                       static_cast<uint16_t>(section->currentPage));
-        ReaderUtils::enforceExitFullRefresh(renderer);
-        startActivityForResult(
-            std::make_unique<EpubReaderMenuActivity>(
-                renderer, mappedInput, epub->getTitle(), currentPage, totalPages, bookProgressPercent,
-                SETTINGS.orientation, !currentPageFootnotes.empty(), bookEmbeddedStyleOverride,
-                bookImageRenderingOverride, bookFontFamilyOverride, bookFontSizeOverride, SETTINGS.textDarkness,
-                !bookmarkStore.isEmpty(), isCurrentPageStarred),
-            [this](const ActivityResult& result) {
-              const auto& menu = std::get<MenuResult>(result.data);
-              applyOrientation(menu.orientation);
-              applyTextDarkness(menu.textDarkness);
-              toggleAutoPageTurn(menu.pageTurnOption);
-              applyBookReaderOverrides(menu.embeddedStyleOverride, menu.imageRenderingOverride, menu.fontFamilyOverride,
-                                       menu.fontSizeOverride);
-              if (!result.isCancelled) {
-                onReaderMenuConfirm(static_cast<EpubReaderMenuActivity::MenuAction>(menu.action));
-              }
-            });
       }
       break;
     case BA::BTN_KOREADER_SYNC:

src/activities/reader/EpubReaderActivity.h

@@ -166,6 +166,7 @@ class EpubReaderActivity final : public Activity {
   void toggleAutoPageTurn(uint8_t selectedPageTurnOption);
   void applyBookReaderOverrides(int8_t embeddedStyleOverride, int8_t imageRenderingOverride, int8_t fontFamilyOverride,
                                 int8_t fontSizeOverride);
+  void openReaderMenu();
   bool getEffectiveEmbeddedStyle() const;
   uint8_t getEffectiveImageRendering() const;
   int getEffectiveReaderFontId() const;

src/activities/reader/EpubReaderChapterSelectionActivity.cpp

@@ -42,7 +42,9 @@ void EpubReaderChapterSelectionActivity::loop() {
   const int pageItems = getPageItems();
   const int totalItems = getTotalItems();
 
-  if (mappedInput.wasReleased(MappedInputManager::Button::Confirm)) {
+  ButtonEventManager::ButtonEvent ev;
+  while (buttonEvents.consumeEvent(ev)) {
+    if (ev.button == MappedInputManager::Button::Confirm && ev.type == ButtonEventManager::PressType::Short) {
       const auto newSpineIndex = epub->getSpineIndexForTocIndex(selectorIndex);
       if (newSpineIndex == -1) {
         ActivityResult result;
@@ -53,11 +55,27 @@ void EpubReaderChapterSelectionActivity::loop() {
         setResult(ChapterResult{newSpineIndex, selectorIndex});
         finish();
       }
-  } else if (mappedInput.wasReleased(MappedInputManager::Button::Back)) {
+      return;
+    }
+    if (ev.button == MappedInputManager::Button::Back && ev.type == ButtonEventManager::PressType::Short) {
       ActivityResult result;
       result.isCancelled = true;
       setResult(std::move(result));
       finish();
+      return;
+    }
+    if ((ev.button == MappedInputManager::Button::PageBack || ev.button == MappedInputManager::Button::Left) &&
+        ev.type == ButtonEventManager::PressType::Short) {
+      selectorIndex = ButtonNavigator::previousIndex(selectorIndex, totalItems);
+      requestUpdate();
+      return;
+    }
+    if ((ev.button == MappedInputManager::Button::PageForward || ev.button == MappedInputManager::Button::Right) &&
+        ev.type == ButtonEventManager::PressType::Short) {
+      selectorIndex = ButtonNavigator::nextIndex(selectorIndex, totalItems);
+      requestUpdate();
+      return;
+    }
   }
 
   buttonNavigator.onNextRelease([this, totalItems] {

src/activities/reader/EpubReaderFootnotesActivity.cpp

@@ -18,7 +18,9 @@ void EpubReaderFootnotesActivity::onEnter() {
 void EpubReaderFootnotesActivity::onExit() { Activity::onExit(); }
 
 void EpubReaderFootnotesActivity::loop() {
-  if (mappedInput.wasReleased(MappedInputManager::Button::Back)) {
+  ButtonEventManager::ButtonEvent ev;
+  while (buttonEvents.consumeEvent(ev)) {
+    if (ev.button == MappedInputManager::Button::Back && ev.type == ButtonEventManager::PressType::Short) {
       ActivityResult result;
       result.isCancelled = true;
       setResult(std::move(result));
@@ -26,7 +28,7 @@ void EpubReaderFootnotesActivity::loop() {
       return;
     }
 
-  if (mappedInput.wasReleased(MappedInputManager::Button::Confirm)) {
+    if (ev.button == MappedInputManager::Button::Confirm && ev.type == ButtonEventManager::PressType::Short) {
       if (selectedIndex >= 0 && selectedIndex < static_cast<int>(footnotes.size())) {
         setResult(FootnoteResult{footnotes[selectedIndex].href});
         finish();
@@ -34,19 +36,35 @@ void EpubReaderFootnotesActivity::loop() {
       return;
     }
 
-  buttonNavigator.onNext([this] {
+    if ((ev.button == MappedInputManager::Button::PageBack || ev.button == MappedInputManager::Button::Left) &&
-    if (!footnotes.empty()) {
+        ev.type == ButtonEventManager::PressType::Short) {
-      selectedIndex = (selectedIndex + 1) % footnotes.size();
+      advanceSelection(-1);
-      requestUpdate();
+      return;
     }
-  });
 
-  buttonNavigator.onPrevious([this] {
+    if ((ev.button == MappedInputManager::Button::PageForward || ev.button == MappedInputManager::Button::Right) &&
-    if (!footnotes.empty()) {
+        ev.type == ButtonEventManager::PressType::Short) {
-      selectedIndex = (selectedIndex - 1 + footnotes.size()) % footnotes.size();
+      advanceSelection(1);
-      requestUpdate();
+      return;
     }
-  });
+  }
+
+  buttonNavigator.onNextRelease([this] { advanceSelection(1); });
+
+  buttonNavigator.onPreviousRelease([this] { advanceSelection(-1); });
+
+  buttonNavigator.onNextContinuous([this] { advanceSelection(1); });
+
+  buttonNavigator.onPreviousContinuous([this] { advanceSelection(-1); });
+}
+
+void EpubReaderFootnotesActivity::advanceSelection(int delta) {
+  if (footnotes.empty()) {
+    return;
+  }
+  const int n = static_cast<int>(footnotes.size());
+  selectedIndex = ((selectedIndex + delta) % n + n) % n;
+  requestUpdate();
 }
 
 void EpubReaderFootnotesActivity::render(RenderLock&&) {

src/activities/reader/EpubReaderFootnotesActivity.h

@@ -21,6 +21,7 @@ class EpubReaderFootnotesActivity final : public Activity {
   void render(RenderLock&&) override;
 
  private:
+  void advanceSelection(int delta);
   const std::vector<FootnoteEntry>& footnotes;
   int selectedIndex = 0;
   int scrollOffset = 0;

src/activities/reader/EpubReaderPercentSelectionActivity.cpp

@@ -34,7 +34,9 @@ void EpubReaderPercentSelectionActivity::adjustPercent(const int delta) {
 
 void EpubReaderPercentSelectionActivity::loop() {
   // Back cancels, confirm selects, arrows adjust the percent.
-  if (mappedInput.wasReleased(MappedInputManager::Button::Back)) {
+  ButtonEventManager::ButtonEvent ev;
+  while (buttonEvents.consumeEvent(ev)) {
+    if (ev.button == MappedInputManager::Button::Back && ev.type == ButtonEventManager::PressType::Short) {
       ActivityResult result;
       result.isCancelled = true;
       setResult(std::move(result));
@@ -42,14 +44,24 @@ void EpubReaderPercentSelectionActivity::loop() {
       return;
     }
 
-  if (mappedInput.wasReleased(MappedInputManager::Button::Confirm)) {
+    if (ev.button == MappedInputManager::Button::Confirm && ev.type == ButtonEventManager::PressType::Short) {
       setResult(PercentResult{percent});
       finish();
       return;
     }
 
-  buttonNavigator.onPressAndContinuous({MappedInputManager::Button::Left}, [this] { adjustPercent(-kSmallStep); });
+    if ((ev.button == MappedInputManager::Button::PageBack || ev.button == MappedInputManager::Button::Left) &&
-  buttonNavigator.onPressAndContinuous({MappedInputManager::Button::Right}, [this] { adjustPercent(kSmallStep); });
+        ev.type == ButtonEventManager::PressType::Short) {
+      adjustPercent(-kSmallStep);
+      return;
+    }
+
+    if ((ev.button == MappedInputManager::Button::PageForward || ev.button == MappedInputManager::Button::Right) &&
+        ev.type == ButtonEventManager::PressType::Short) {
+      adjustPercent(kSmallStep);
+      return;
+    }
+  }
 
   buttonNavigator.onPressAndContinuous({MappedInputManager::Button::Up}, [this] { adjustPercent(kLargeStep); });
   buttonNavigator.onPressAndContinuous({MappedInputManager::Button::Down}, [this] { adjustPercent(-kLargeStep); });

src/activities/reader/MdReaderActivity.cpp

@@ -23,7 +23,6 @@
 namespace {
 constexpr size_t CHUNK_SIZE = 8 * 1024;
 constexpr size_t MAX_LINE_LENGTH = 64 * 1024;
-constexpr unsigned long HEADING_SKIP_MS = 700;
 constexpr uint32_t CACHE_MAGIC = 0x4D4B4449;  // "MKDI"
 constexpr uint8_t CACHE_VERSION = 3;          // Bumped: nested list indent + task checkboxes
 
@@ -39,6 +38,8 @@ static std::string flattenHeadingText(const MdParser::ParsedLine& parsed) {
 void MdReaderActivity::onEnter() {
   Activity::onEnter();
 
+  inputDrainGuard.arm();
+
   if (!txt) {
     return;
   }
@@ -222,18 +223,26 @@ void MdReaderActivity::onExit() {
 }
 
 void MdReaderActivity::loop() {
-  if (mappedInput.isPressed(MappedInputManager::Button::Back) && mappedInput.getHeldTime() >= ReaderUtils::GO_HOME_MS) {
+  if (inputDrainGuard.shouldDrain(mappedInput)) {
+    buttonEvents.drain();
+    return;
+  }
+
+  ButtonEventManager::ButtonEvent ev;
+  while (buttonEvents.consumeEvent(ev)) {
+    if (ev.button == MappedInputManager::Button::Back) {
+      if (ev.type == ButtonEventManager::PressType::Long) {
         activityManager.goToFileBrowser(txt ? txt->getPath() : "");
         return;
       }
-
+      if (ev.type == ButtonEventManager::PressType::Short) {
-  if (mappedInput.wasReleased(MappedInputManager::Button::Back) &&
-      mappedInput.getHeldTime() < ReaderUtils::GO_HOME_MS) {
         onGoHome();
         return;
       }
+    }
 
-  if (mappedInput.wasReleased(MappedInputManager::Button::Confirm) && !headings.empty()) {
+    if (!headings.empty() && ev.button == MappedInputManager::Button::Confirm &&
+        ev.type == ButtonEventManager::PressType::Short) {
       currentHeadingIndex = getHeadingIndexForOffset(pageOffsets[currentPage]);
       ReaderUtils::enforceExitFullRefresh(renderer);
       startActivityForResult(
@@ -248,22 +257,18 @@ void MdReaderActivity::loop() {
       return;
     }
 
-  auto [prevTriggered, nextTriggered] = ReaderUtils::detectPageTurn(mappedInput);
+    if ((ev.button == MappedInputManager::Button::PageBack || ev.button == MappedInputManager::Button::Left) &&
-  if (!prevTriggered && !nextTriggered) {
+        ev.type == ButtonEventManager::PressType::Short) {
-    return;
+      if (currentPage > 0) {
-  }
-
-  const bool headingSkip = mappedInput.getHeldTime() > HEADING_SKIP_MS;
-  if (headingSkip && !headings.empty()) {
-    jumpToHeading(nextTriggered);
-    return;
-  }
-
-  if (prevTriggered && currentPage > 0) {
         currentPage--;
         currentHeadingIndex = getHeadingIndexForOffset(pageOffsets[currentPage]);
         requestUpdate();
-  } else if (nextTriggered) {
+      }
+      return;
+    }
+
+    if ((ev.button == MappedInputManager::Button::PageForward || ev.button == MappedInputManager::Button::Right) &&
+        ev.type == ButtonEventManager::PressType::Short) {
       if (currentPage < totalPages - 1) {
         currentPage++;
         currentHeadingIndex = getHeadingIndexForOffset(pageOffsets[currentPage]);
@@ -271,6 +276,8 @@ void MdReaderActivity::loop() {
       } else {
         onGoHome();
       }
+      return;
+    }
   }
 }
 

src/activities/reader/MdReaderActivity.h

@@ -6,6 +6,7 @@
 #include <vector>
 
 #include "CrossPointSettings.h"
+#include "ReaderUtils.h"
 #include "activities/Activity.h"
 
 struct MdHeading {
@@ -72,6 +73,7 @@ class MdReaderActivity final : public Activity {
   void assignHeadingPageNumbers();
   int getHeadingIndexForOffset(size_t offset) const;
   void jumpToHeading(bool next);
+  ReaderUtils::InputDrainGuard inputDrainGuard;
 
   // Word-wrap a parsed markdown line into one or more RenderedLines.
   // Returns true if all content was emitted, false if truncated by maxLines.

src/activities/reader/MdReaderTocSelectionActivity.cpp

@@ -34,7 +34,9 @@ void MdReaderTocSelectionActivity::loop() {
   const int pageItems = getPageItems();
   const int totalItems = getTotalItems();
 
-  if (mappedInput.wasReleased(MappedInputManager::Button::Confirm)) {
+  ButtonEventManager::ButtonEvent ev;
+  while (buttonEvents.consumeEvent(ev)) {
+    if (ev.button == MappedInputManager::Button::Confirm && ev.type == ButtonEventManager::PressType::Short) {
       if (selectorIndex >= 0 && selectorIndex < totalItems) {
         setResult(PageResult{static_cast<uint32_t>(headings[selectorIndex].pageIndex)});
       } else {
@@ -46,7 +48,7 @@ void MdReaderTocSelectionActivity::loop() {
       return;
     }
 
-  if (mappedInput.wasReleased(MappedInputManager::Button::Back)) {
+    if (ev.button == MappedInputManager::Button::Back && ev.type == ButtonEventManager::PressType::Short) {
       ActivityResult result;
       result.isCancelled = true;
       setResult(std::move(result));
@@ -54,6 +56,21 @@ void MdReaderTocSelectionActivity::loop() {
       return;
     }
 
+    if ((ev.button == MappedInputManager::Button::PageBack || ev.button == MappedInputManager::Button::Left) &&
+        ev.type == ButtonEventManager::PressType::Short) {
+      selectorIndex = ButtonNavigator::previousIndex(selectorIndex, totalItems);
+      requestUpdate();
+      return;
+    }
+
+    if ((ev.button == MappedInputManager::Button::PageForward || ev.button == MappedInputManager::Button::Right) &&
+        ev.type == ButtonEventManager::PressType::Short) {
+      selectorIndex = ButtonNavigator::nextIndex(selectorIndex, totalItems);
+      requestUpdate();
+      return;
+    }
+  }
+
   buttonNavigator.onNextRelease([this, totalItems] {
     selectorIndex = ButtonNavigator::nextIndex(selectorIndex, totalItems);
     requestUpdate();

src/activities/reader/QrDisplayActivity.cpp

@@ -16,12 +16,15 @@ void QrDisplayActivity::onEnter() {
 void QrDisplayActivity::onExit() { Activity::onExit(); }
 
 void QrDisplayActivity::loop() {
-  if (mappedInput.wasReleased(MappedInputManager::Button::Back) ||
+  ButtonEventManager::ButtonEvent ev;
-      mappedInput.wasReleased(MappedInputManager::Button::Confirm)) {
+  while (buttonEvents.consumeEvent(ev)) {
+    if ((ev.button == MappedInputManager::Button::Back || ev.button == MappedInputManager::Button::Confirm) &&
+        ev.type == ButtonEventManager::PressType::Short) {
       finish();
       return;
     }
   }
+}
 
 void QrDisplayActivity::render(RenderLock&&) {
   renderer.clearScreen();

src/activities/reader/ReaderUtils.h

@@ -6,6 +6,7 @@
 
 #include <cstdint>
 
+#include "ButtonEventManager.h"
 #include "MappedInputManager.h"
 
 namespace ReaderUtils {
@@ -90,13 +91,21 @@ inline PageTurnResult detectPageTurn(const MappedInputManager& input) {
   // Only treat wasReleased as a page turn when the button's short-press action is default.
   // Non-default short-press actions are dispatched by the global dispatcher in main.cpp;
   // counting wasReleased as well would double-fire the action.
+  // Also suppress immediate page-turns if a double-click action is configured for the button,
+  // because the button event system delays short events until the double-click window expires.
   using BA = CrossPointSettings::BUTTON_ACTION;
-  const bool prev =
+  const bool prev = (SETTINGS.btnShortPageBack == BA::BTN_DEFAULT &&
-      (SETTINGS.btnShortPageBack == BA::BTN_DEFAULT && input.wasReleased(MappedInputManager::Button::PageBack)) ||
+                     !ButtonEventManager::hasDoubleAction(MappedInputManager::Button::PageBack) &&
-      (SETTINGS.btnShortLeft == BA::BTN_DEFAULT && input.wasReleased(MappedInputManager::Button::Left));
+                     input.wasReleased(MappedInputManager::Button::PageBack)) ||
-  const bool next =
+                    (SETTINGS.btnShortLeft == BA::BTN_DEFAULT &&
-      (SETTINGS.btnShortPageForward == BA::BTN_DEFAULT && input.wasReleased(MappedInputManager::Button::PageForward)) ||
+                     !ButtonEventManager::hasDoubleAction(MappedInputManager::Button::Left) &&
-      (SETTINGS.btnShortRight == BA::BTN_DEFAULT && input.wasReleased(MappedInputManager::Button::Right));
+                     input.wasReleased(MappedInputManager::Button::Left));
+  const bool next = (SETTINGS.btnShortPageForward == BA::BTN_DEFAULT &&
+                     !ButtonEventManager::hasDoubleAction(MappedInputManager::Button::PageForward) &&
+                     input.wasReleased(MappedInputManager::Button::PageForward)) ||
+                    (SETTINGS.btnShortRight == BA::BTN_DEFAULT &&
+                     !ButtonEventManager::hasDoubleAction(MappedInputManager::Button::Right) &&
+                     input.wasReleased(MappedInputManager::Button::Right));
   return {prev, next};
 }
 

src/activities/reader/StarredPagesActivity.cpp

@@ -78,7 +78,9 @@ void StarredPagesActivity::deleteSelected() {
 void StarredPagesActivity::loop() {
   const int totalItems = static_cast<int>(bookmarkStore.getAll().size());
 
-  if (mappedInput.wasReleased(MappedInputManager::Button::Back)) {
+  ButtonEventManager::ButtonEvent ev;
+  while (buttonEvents.consumeEvent(ev)) {
+    if (ev.button == MappedInputManager::Button::Back && ev.type == ButtonEventManager::PressType::Short) {
       ActivityResult result;
       result.isCancelled = true;
       setResult(std::move(result));
@@ -86,24 +88,30 @@ void StarredPagesActivity::loop() {
       return;
     }
 
-  if (totalItems == 0) return;
+    if (totalItems > 0 && ev.button == MappedInputManager::Button::Confirm &&
-
+        ev.type == ButtonEventManager::PressType::Short) {
-  if (mappedInput.wasReleased(MappedInputManager::Button::Confirm)) {
       const auto& bm = bookmarkStore.getAll()[selectorIndex];
       setResult(StarredPageResult{bm.spineIndex, bm.pageNumber});
       finish();
       return;
     }
 
-  if (mappedInput.wasReleased(MappedInputManager::Button::Left)) {
+    if (totalItems > 0 &&
+        (ev.button == MappedInputManager::Button::PageBack || ev.button == MappedInputManager::Button::Left) &&
+        ev.type == ButtonEventManager::PressType::Short) {
       startRename();
       return;
     }
 
-  if (mappedInput.wasReleased(MappedInputManager::Button::Right)) {
+    if (totalItems > 0 &&
+        (ev.button == MappedInputManager::Button::PageForward || ev.button == MappedInputManager::Button::Right) &&
+        ev.type == ButtonEventManager::PressType::Short) {
       deleteSelected();
       return;
     }
+  }
+
+  if (totalItems == 0) return;
 
   const int pageItems = UITheme::getInstance().getNumberOfItemsPerPage(renderer, true, false, true, false);
 

src/activities/reader/TxtReaderActivity.cpp

@@ -137,26 +137,27 @@ void TxtReaderActivity::onExit() {
 
 void TxtReaderActivity::loop() {
   if (inputDrainGuard.shouldDrain(mappedInput)) {
+    buttonEvents.drain();
     return;
   }
 
-  // Long press BACK (1s+) goes to home screen
+  ButtonEventManager::ButtonEvent ev;
-  if (mappedInput.isPressed(MappedInputManager::Button::Back) && mappedInput.getHeldTime() >= ReaderUtils::GO_HOME_MS) {
+  while (buttonEvents.consumeEvent(ev)) {
+    if (ev.button == MappedInputManager::Button::Back) {
+      if (ev.type == ButtonEventManager::PressType::Long) {
         ReaderUtils::enforceExitFullRefresh(renderer);
         onGoHome();
         return;
       }
-
+      if (ev.type == ButtonEventManager::PressType::Short) {
-  // Short press BACK returns to the calling activity
-  if (mappedInput.wasReleased(MappedInputManager::Button::Back) &&
-      mappedInput.getHeldTime() < ReaderUtils::GO_HOME_MS) {
         ReaderUtils::enforceExitFullRefresh(renderer);
         finish();
         return;
       }
+    }
 
-  // Open starred pages list via Confirm button
+    if (!bookmarkStore.isEmpty() && ev.button == MappedInputManager::Button::Confirm &&
-  if (mappedInput.wasReleased(MappedInputManager::Button::Confirm) && !bookmarkStore.isEmpty()) {
+        ev.type == ButtonEventManager::PressType::Short) {
       ReaderUtils::enforceExitFullRefresh(renderer);
       startActivityForResult(std::make_unique<StarredPagesActivity>(renderer, mappedInput, bookmarkStore),
                              [this](const ActivityResult& result) {
@@ -171,21 +172,25 @@ void TxtReaderActivity::loop() {
       return;
     }
 
-  auto [prevTriggered, nextTriggered] = ReaderUtils::detectPageTurn(mappedInput);
+    if ((ev.button == MappedInputManager::Button::PageBack || ev.button == MappedInputManager::Button::Left) &&
-  if (!prevTriggered && !nextTriggered) {
+        ev.type == ButtonEventManager::PressType::Short) {
+      if (currentPage > 0) {
+        currentPage--;
+        requestUpdate();
+      }
       return;
     }
 
-  if (prevTriggered && currentPage > 0) {
+    if ((ev.button == MappedInputManager::Button::PageForward || ev.button == MappedInputManager::Button::Right) &&
-    currentPage--;
+        ev.type == ButtonEventManager::PressType::Short) {
-    requestUpdate();
-  } else if (nextTriggered) {
       if (currentPage < totalPages - 1) {
         currentPage++;
         requestUpdate();
       } else {
         finish();
       }
+      return;
+    }
   }
 }
 

src/activities/reader/XtcReaderActivity.cpp

@@ -22,11 +22,6 @@
 #include "XtcReaderChapterSelectionActivity.h"
 #include "fontIds.h"
 
-namespace {
-constexpr unsigned long skipPageMs = 700;
-constexpr unsigned long goHomeMs = 1000;
-}  // namespace
-
 void XtcReaderActivity::onEnter() {
   Activity::onEnter();
 
@@ -62,11 +57,17 @@ void XtcReaderActivity::onExit() {
 
 void XtcReaderActivity::loop() {
   if (inputDrainGuard.shouldDrain(mappedInput)) {
+    buttonEvents.drain();
     return;
   }
 
-  // Enter chapter selection activity
+  bool delayedPrevTurn = false;
-  if (mappedInput.wasReleased(MappedInputManager::Button::Confirm)) {
+  bool delayedNextTurn = false;
+  using BA = CrossPointSettings::BUTTON_ACTION;
+
+  ButtonEventManager::ButtonEvent ev;
+  while (buttonEvents.consumeEvent(ev)) {
+    if (ev.button == MappedInputManager::Button::Confirm && ev.type == ButtonEventManager::PressType::Short) {
       if (xtc && xtc->hasChapters() && !xtc->getChapters().empty()) {
         ReaderUtils::enforceExitFullRefresh(renderer);
         startActivityForResult(
@@ -76,27 +77,49 @@ void XtcReaderActivity::loop() {
                 currentPage = std::get<PageResult>(result.data).page;
               }
             });
+        return;
       }
     }
 
-  // Long press BACK (1s+) goes to home screen
+    if (ev.button == MappedInputManager::Button::Back) {
-  if (mappedInput.isPressed(MappedInputManager::Button::Back) && mappedInput.getHeldTime() >= goHomeMs) {
+      if (ev.type == ButtonEventManager::PressType::Long) {
         ReaderUtils::enforceExitFullRefresh(renderer);
         onGoHome();
         return;
       }
-
+      if (ev.type == ButtonEventManager::PressType::Short) {
-  // Short press BACK returns to the calling activity
-  if (mappedInput.wasReleased(MappedInputManager::Button::Back) && mappedInput.getHeldTime() < goHomeMs) {
         ReaderUtils::enforceExitFullRefresh(renderer);
         finish();
         return;
       }
+    }
 
-  const bool prevTriggered = mappedInput.wasReleased(MappedInputManager::Button::PageBack) ||
+    if (ev.type == ButtonEventManager::PressType::Short) {
-                             mappedInput.wasReleased(MappedInputManager::Button::Left);
+      if ((ev.button == MappedInputManager::Button::PageBack && SETTINGS.btnShortPageBack == BA::BTN_DEFAULT &&
-  const bool nextTriggered = mappedInput.wasReleased(MappedInputManager::Button::PageForward) ||
+           ButtonEventManager::hasDoubleAction(MappedInputManager::Button::PageBack)) ||
-                             mappedInput.wasReleased(MappedInputManager::Button::Right);
+          (ev.button == MappedInputManager::Button::Left && SETTINGS.btnShortLeft == BA::BTN_DEFAULT &&
+           ButtonEventManager::hasDoubleAction(MappedInputManager::Button::Left))) {
+        delayedPrevTurn = true;
+        continue;
+      }
+      if ((ev.button == MappedInputManager::Button::PageForward && SETTINGS.btnShortPageForward == BA::BTN_DEFAULT &&
+           ButtonEventManager::hasDoubleAction(MappedInputManager::Button::PageForward)) ||
+          (ev.button == MappedInputManager::Button::Right && SETTINGS.btnShortRight == BA::BTN_DEFAULT &&
+           ButtonEventManager::hasDoubleAction(MappedInputManager::Button::Right))) {
+        delayedNextTurn = true;
+        continue;
+      }
+    }
+  }
+
+  auto [prevTriggered, nextTriggered] = ReaderUtils::detectPageTurn(mappedInput);
+  if (!prevTriggered && !nextTriggered) {
+    if (!delayedPrevTurn && !delayedNextTurn) {
+      return;
+    }
+    prevTriggered = delayedPrevTurn;
+    nextTriggered = delayedNextTurn;
+  }
 
   if (!prevTriggered && !nextTriggered) {
     return;
@@ -113,21 +136,13 @@ void XtcReaderActivity::loop() {
     return;
   }
 
-  const bool skipPages = mappedInput.getHeldTime() > skipPageMs;
-  const int skipAmount = skipPages ? 10 : 1;
-
   if (prevTriggered) {
-    if (currentPage >= static_cast<uint32_t>(skipAmount)) {
+    if (currentPage > 0) {
-      currentPage -= skipAmount;
+      currentPage--;
-    } else {
-      currentPage = 0;
-    }
       requestUpdate();
-  } else if (nextTriggered) {
-    currentPage += skipAmount;
-    if (currentPage >= xtc->getPageCount()) {
-      currentPage = xtc->getPageCount();  // Allow showing "End of book"
     }
+  } else if (nextTriggered) {
+    currentPage++;
     requestUpdate();
   }
 }

src/activities/reader/XtcReaderChapterSelectionActivity.cpp

@@ -5,6 +5,7 @@
 
 #include <algorithm>
 
+#include "ButtonEventManager.h"
 #include "MappedInputManager.h"
 #include "components/UITheme.h"
 #include "fontIds.h"
@@ -47,28 +48,58 @@ void XtcReaderChapterSelectionActivity::onEnter() {
 void XtcReaderChapterSelectionActivity::onExit() { Activity::onExit(); }
 
 void XtcReaderChapterSelectionActivity::loop() {
+  if (!xtc) {
+    return;
+  }
+
   const int pageItems = getPageItems();
   const int totalItems = static_cast<int>(xtc->getChapters().size());
 
-  if (mappedInput.wasReleased(MappedInputManager::Button::Confirm)) {
+  ButtonEventManager::ButtonEvent ev;
+  while (buttonEvents.consumeEvent(ev)) {
+    if (ev.button == MappedInputManager::Button::Confirm && ev.type == ButtonEventManager::PressType::Short) {
       const auto& chapters = xtc->getChapters();
       if (!chapters.empty() && selectorIndex >= 0 && selectorIndex < static_cast<int>(chapters.size())) {
         setResult(PageResult{chapters[selectorIndex].startPage});
         finish();
       }
-  } else if (mappedInput.wasReleased(MappedInputManager::Button::Back)) {
+      return;
+    }
+    if (ev.button == MappedInputManager::Button::Back && ev.type == ButtonEventManager::PressType::Short) {
       ActivityResult result;
       result.isCancelled = true;
       setResult(std::move(result));
       finish();
+      return;
+    }
+    if ((ev.button == MappedInputManager::Button::PageBack || ev.button == MappedInputManager::Button::Left) &&
+        ev.type == ButtonEventManager::PressType::Short) {
+      selectorIndex = ButtonNavigator::previousIndex(selectorIndex, totalItems);
+      requestUpdate();
+      return;
+    }
+    if ((ev.button == MappedInputManager::Button::PageForward || ev.button == MappedInputManager::Button::Right) &&
+        ev.type == ButtonEventManager::PressType::Short) {
+      selectorIndex = ButtonNavigator::nextIndex(selectorIndex, totalItems);
+      requestUpdate();
+      return;
+    }
   }
 
   buttonNavigator.onNextRelease([this, totalItems] {
+    if (ButtonEventManager::hasDoubleAction(MappedInputManager::Button::Right) ||
+        ButtonEventManager::hasDoubleAction(MappedInputManager::Button::PageForward)) {
+      return;
+    }
     selectorIndex = ButtonNavigator::nextIndex(selectorIndex, totalItems);
     requestUpdate();
   });
 
   buttonNavigator.onPreviousRelease([this, totalItems] {
+    if (ButtonEventManager::hasDoubleAction(MappedInputManager::Button::Left) ||
+        ButtonEventManager::hasDoubleAction(MappedInputManager::Button::PageBack)) {
+      return;
+    }
     selectorIndex = ButtonNavigator::previousIndex(selectorIndex, totalItems);
     requestUpdate();
   });

src/activities/util/BmpViewerActivity.cpp

@@ -388,38 +388,38 @@ void BmpViewerActivity::loop() {
   // Keep CPU awake/polling so 1st click works
   Activity::loop();
 
-  // Long press BACK (1s+) goes to home screen
+  const bool toggleSupported = isBmpFile(filePath) ? bmpHasGreyscale : true;
-  if (mappedInput.isPressed(MappedInputManager::Button::Back) && mappedInput.getHeldTime() >= ReaderUtils::GO_HOME_MS) {
+  ButtonEventManager::ButtonEvent ev;
+  while (buttonEvents.consumeEvent(ev)) {
+    if (ev.button == MappedInputManager::Button::Back) {
+      if (ev.type == ButtonEventManager::PressType::Long) {
         onGoHome();
         return;
       }
-
+      if (ev.type == ButtonEventManager::PressType::Short) {
-  // Short press BACK returns to the calling activity
-  if (mappedInput.wasReleased(MappedInputManager::Button::Back) &&
-      mappedInput.getHeldTime() < ReaderUtils::GO_HOME_MS) {
         finish();
         return;
       }
+    }
 
-  // Confirm: toggle between 1-bit B&W and 4-level grayscale display.
+    if (ev.button == MappedInputManager::Button::Confirm && ev.type == ButtonEventManager::PressType::Short) {
-  // For decoded images this always applies; for BMPs it only makes sense when the bitmap
+      if (toggleSupported) {
-  // actually carries greyscale data (1-bit BMPs have nothing to toggle).
-  const bool toggleSupported = isBmpFile(filePath) ? bmpHasGreyscale : true;
-  if (toggleSupported && mappedInput.wasReleased(MappedInputManager::Button::Confirm)) {
         toggleDisplayMode();
+      }
       return;
     }
 
 #ifdef ENABLE_IMAGE_DITHERING_EXTENSION
-  if (!isBmpFile(filePath) && grayscaleDisplay && mappedInput.wasReleased(MappedInputManager::Button::Left)) {
+    if (ev.button == MappedInputManager::Button::Left && ev.type == ButtonEventManager::PressType::Short &&
+        !isBmpFile(filePath) && grayscaleDisplay) {
       cycleDitherMode();
       return;
     }
 #endif
 
-  // Next/Right button: set this image as the sleep screen
+    if (ev.button == MappedInputManager::Button::Right && ev.type == ButtonEventManager::PressType::Short) {
-  if (mappedInput.wasReleased(MappedInputManager::Button::Right)) {
       setAsSleepScreen();
       return;
     }
   }
+}

src/main.cpp

@@ -16,6 +16,7 @@
 #include <esp_ota_ops.h>
 
 #include <cstring>
+#include <vector>
 
 #include "ButtonEventManager.h"
 #include "CrossPointSettings.h"
@@ -387,10 +388,8 @@ void loop() {
   {
     using BA = CrossPointSettings::BUTTON_ACTION;
     using B = MappedInputManager::Button;
-    ButtonEventManager::ButtonEvent ev;
+    auto actionFor = [&](const ButtonEventManager::ButtonEvent& ev) -> uint8_t {
-    while (buttonEventManager.consumeEvent(ev)) {
+      switch (ev.button) {
-      auto actionFor = [&](B btn) -> uint8_t {
-        switch (btn) {
         case B::Back:
           switch (ev.type) {
             case ButtonEventManager::PressType::Short:
@@ -466,9 +465,18 @@ void loop() {
       }
       return BA::BTN_DEFAULT;
     };
-
+    ButtonEventManager::ButtonEvent ev;
-      const uint8_t action = actionFor(ev.button);
+    std::vector<ButtonEventManager::ButtonEvent> defaultEvents;
-      if (action == BA::BTN_DEFAULT) continue;
+    defaultEvents.reserve(8);
+    while (buttonEventManager.consumeEvent(ev)) {
+      const uint8_t action = actionFor(ev);
+      if (action == BA::BTN_DEFAULT) {
+        if (ev.type == ButtonEventManager::PressType::Double) {
+          continue;
+        }
+        defaultEvents.push_back(ev);
+        continue;
+      }
 
       switch (static_cast<BA>(action)) {
         case BA::BTN_PAGE_FORWARD:
@@ -525,6 +533,10 @@ void loop() {
           break;
       }
     }
+
+    for (auto it = defaultEvents.rbegin(); it != defaultEvents.rend(); ++it) {
+      buttonEventManager.pushEventFront(it->button, it->type);
+    }
   }
 
   const unsigned long activityStartTime = millis();