Review comments
This commit is contained in:
+9
-2
@@ -111,8 +111,15 @@ class BookmarkStore {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
ok = ok && f.close();
|
bool closeOk = false;
|
||||||
if (!ok) {
|
if (ok) {
|
||||||
|
closeOk = f.close();
|
||||||
|
if (!closeOk) {
|
||||||
|
LOG_ERR("BKM", "Failed to close bookmarks file");
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
f.close();
|
||||||
LOG_ERR("BKM", "Failed while writing bookmarks");
|
LOG_ERR("BKM", "Failed while writing bookmarks");
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -26,7 +26,6 @@ class EpubReaderMenuActivity final : public MenuListActivity {
|
|||||||
GO_HOME,
|
GO_HOME,
|
||||||
PULL_REMOTE,
|
PULL_REMOTE,
|
||||||
PUSH_LOCAL,
|
PUSH_LOCAL,
|
||||||
SYNC,
|
|
||||||
STARRED_PAGES,
|
STARRED_PAGES,
|
||||||
STAR_PAGE,
|
STAR_PAGE,
|
||||||
DELETE_CACHE
|
DELETE_CACHE
|
||||||
|
|||||||
@@ -153,7 +153,9 @@ void TxtReaderActivity::loop() {
|
|||||||
// Star page toggle via short power button press
|
// Star page toggle via short power button press
|
||||||
if (SETTINGS.shortPwrBtn == CrossPointSettings::SHORT_PWRBTN::STAR_PAGE &&
|
if (SETTINGS.shortPwrBtn == CrossPointSettings::SHORT_PWRBTN::STAR_PAGE &&
|
||||||
mappedInput.wasReleased(MappedInputManager::Button::Power)) {
|
mappedInput.wasReleased(MappedInputManager::Button::Power)) {
|
||||||
bookmarkStore.toggle(0, static_cast<uint16_t>(currentPage));
|
if (currentPage >= 0) {
|
||||||
|
bookmarkStore.toggle(0, static_cast<uint16_t>(currentPage));
|
||||||
|
}
|
||||||
requestUpdate();
|
requestUpdate();
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -866,7 +866,8 @@ void BaseTheme::drawStatusBar(GfxRenderer& renderer, const float bookProgress, c
|
|||||||
// No progress text, place star at right edge
|
// No progress text, place star at right edge
|
||||||
starX = renderer.getScreenWidth() - metrics.statusBarHorizontalMargin - orientedMarginRight - starWidth;
|
starX = renderer.getScreenWidth() - metrics.statusBarHorizontalMargin - orientedMarginRight - starWidth;
|
||||||
}
|
}
|
||||||
renderer.drawText(SMALL_FONT_ID, starX, textY + textYOffset, "*");
|
const int starY = title.empty() ? textY : (textY + textYOffset);
|
||||||
|
renderer.drawText(SMALL_FONT_ID, starX, starY, "*");
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user