eric/Crosspoint
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fail closed if the header patch seek fails

Browse Source
This commit is contained in:
jpirnay
2026-05-12 12:19:44 +02:00
parent aac1a65b82
commit ca04badfed
1 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/Epub/Epub/Section.cpp
+17 -1
View File
@@ -572,7 +572,13 @@ bool Section::createSectionFile(const int fontId, const float lineCompression, c
}
// Patch header with final parseComplete/pageCount and offsets.
file.seek(HEADER_TAIL_PARSE_COMPLETE_OFFSET);
const size_t headerPatchStart = HEADER_TAIL_PARSE_COMPLETE_OFFSET;
if (!file.seek(headerPatchStart)) {
LOG_ERR("SCT", "Failed to seek to section header patch offset %u", HEADER_TAIL_PARSE_COMPLETE_OFFSET);
file.close();
Storage.remove(filePath.c_str());
return false;
}
serialization::writePod(file, parseComplete);
serialization::writePod(file, pageCount);
serialization::writePod(file, lutOffset);
@@ -580,6 +586,16 @@ bool Section::createSectionFile(const int fontId, const float lineCompression, c
serialization::writePod(file, paragraphLutOffset);
file.flush();
const size_t expectedHeaderPatchEnd = headerPatchStart + sizeof(parseComplete) + sizeof(pageCount) +
sizeof(lutOffset) + sizeof(anchorMapOffset) + sizeof(paragraphLutOffset);
if (file.position() != expectedHeaderPatchEnd) {
LOG_ERR("SCT", "Section header patch write failed: wrote %u bytes at offset %u",
static_cast<unsigned>(file.position() - headerPatchStart), static_cast<unsigned>(headerPatchStart));
file.close();
Storage.remove(filePath.c_str());
return false;
}
if (cssParser) {
cssParser->clear();
}