Review fixes

This commit is contained in:
jpirnay
2026-04-12 22:25:12 +02:00
parent d2b13e7a43
commit bec30e3403
4 changed files with 27 additions and 8 deletions
+3 -3
View File
@@ -73,9 +73,9 @@ void SettingInfo::toggleValue() const {
case SettingType::VALUE:
if (valuePtr) {
const auto current = static_cast<int8_t>(SETTINGS.*(valuePtr));
SETTINGS.*(valuePtr) =
(current + valueRange.step > valueRange.max) ? valueRange.min : current + valueRange.step;
const unsigned current = SETTINGS.*(valuePtr);
SETTINGS.*(valuePtr) = static_cast<uint8_t>(
(current + valueRange.step > valueRange.max) ? valueRange.min : current + valueRange.step);
}
break;
-3
View File
@@ -204,12 +204,9 @@ void setup() {
HalSystem::checkPanic();
HalSystem::clearPanic(); // TODO: move this to an activity when we have one to display the panic info
LOG_DBG("MAIN", "System initialized, now setting up environment, millis=%lu", millis());
SETTINGS.loadFromFile();
LOG_DBG("MAIN", "Settings loaded, now setting up clock and localization, millis=%lu", millis());
HalClock::applyTimezone(SETTINGS.timeZone);
I18N.loadSettings();
LOG_DBG("MAIN", "Localization loaded, now setting up theme and button navigation, millis=%lu", millis());
KOREADER_STORE.loadFromFile();
WEATHER_SETTINGS.loadFromFile();
UITheme::getInstance().reload();