eric/Crosspoint
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Drop redundant self-class prefix on applyDirectionToEntry (#2325)

Browse Source 
## Summary

Non-functional cleanup: `ChapterHtmlSlimParser::` prefix is redundant
when calling `applyDirectionToEntry` within `ChapterHtmlSlimParser`
methods.

---

### AI Usage

Did you use AI tools to help write this code? _**NO**_
This commit is contained in:
Zach Nelson
2026-06-11 10:38:00 -04:00
committed by GitHub
parent 301f1d1a38
commit 9202522a39
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/Epub/Epub/parsers/ChapterHtmlSlimParser.cpp
+5 -5
View File
@@ -758,7 +758,7 @@ void XMLCALL ChapterHtmlSlimParser::startElement(void* userData, const XML_Char*
entry.depth = self->depth; entry.depth = self->depth;
entry.hasUnderline = true; entry.hasUnderline = true;
entry.underline = true; entry.underline = true;
ChapterHtmlSlimParser::applyDirectionToEntry(entry, cssStyle); applyDirectionToEntry(entry, cssStyle);
self->inlineStyleStack.push_back(entry); self->inlineStyleStack.push_back(entry);
self->updateEffectiveInlineStyle(); self->updateEffectiveInlineStyle();
@@ -843,7 +843,7 @@ void XMLCALL ChapterHtmlSlimParser::startElement(void* userData, const XML_Char*
entry.hasItalic = true; entry.hasItalic = true;
entry.italic = cssStyle.fontStyle == CssFontStyle::Italic; entry.italic = cssStyle.fontStyle == CssFontStyle::Italic;
} }
ChapterHtmlSlimParser::applyDirectionToEntry(entry, cssStyle); applyDirectionToEntry(entry, cssStyle);
self->inlineStyleStack.push_back(entry); self->inlineStyleStack.push_back(entry);
self->updateEffectiveInlineStyle(); self->updateEffectiveInlineStyle();
} else if (matches(name, BOLD_TAGS, std::size(BOLD_TAGS))) { } else if (matches(name, BOLD_TAGS, std::size(BOLD_TAGS))) {
@@ -866,7 +866,7 @@ void XMLCALL ChapterHtmlSlimParser::startElement(void* userData, const XML_Char*
entry.hasUnderline = true; entry.hasUnderline = true;
entry.underline = cssStyle.textDecoration == CssTextDecoration::Underline; entry.underline = cssStyle.textDecoration == CssTextDecoration::Underline;
} }
ChapterHtmlSlimParser::applyDirectionToEntry(entry, cssStyle); applyDirectionToEntry(entry, cssStyle);
self->inlineStyleStack.push_back(entry); self->inlineStyleStack.push_back(entry);
self->updateEffectiveInlineStyle(); self->updateEffectiveInlineStyle();
} else if (matches(name, ITALIC_TAGS, std::size(ITALIC_TAGS))) { } else if (matches(name, ITALIC_TAGS, std::size(ITALIC_TAGS))) {
@@ -889,7 +889,7 @@ void XMLCALL ChapterHtmlSlimParser::startElement(void* userData, const XML_Char*
entry.hasUnderline = true; entry.hasUnderline = true;
entry.underline = cssStyle.textDecoration == CssTextDecoration::Underline; entry.underline = cssStyle.textDecoration == CssTextDecoration::Underline;
} }
ChapterHtmlSlimParser::applyDirectionToEntry(entry, cssStyle); applyDirectionToEntry(entry, cssStyle);
self->inlineStyleStack.push_back(entry); self->inlineStyleStack.push_back(entry);
self->updateEffectiveInlineStyle(); self->updateEffectiveInlineStyle();
} else if (strcmp(name, "sup") == 0 || strcmp(name, "sub") == 0) { } else if (strcmp(name, "sup") == 0 || strcmp(name, "sub") == 0) {
@@ -931,7 +931,7 @@ void XMLCALL ChapterHtmlSlimParser::startElement(void* userData, const XML_Char*
entry.hasUnderline = true; entry.hasUnderline = true;
entry.underline = cssStyle.textDecoration == CssTextDecoration::Underline; entry.underline = cssStyle.textDecoration == CssTextDecoration::Underline;
} }
ChapterHtmlSlimParser::applyDirectionToEntry(entry, cssStyle); applyDirectionToEntry(entry, cssStyle);
if (cssStyle.hasVerticalAlign()) { if (cssStyle.hasVerticalAlign()) {
if (cssStyle.verticalAlign == CssVerticalAlign::Super) { if (cssStyle.verticalAlign == CssVerticalAlign::Super) {
entry.hasSup = true; entry.hasSup = true;