fix: properly implement requestUpdateAndWait() (#1218)
## Summary Properly implement `requestUpdateAndWait()` using freeRTOS direct task notification. FWIW, I think most of the current use cases of `requestUpdateAndWait()` are redundant, better to be replaced by `requestUpdate(true)`. But just keeping them in case we can find a proper use case for it in the future. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? **YES**, it's trivial, so I asked an AI to write the code --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This commit is contained in:
committed by
GitHub
co-authored by
coderabbitai[bot]
parent
e600befd35
commit
8b176d8645
@@ -8,11 +8,7 @@ void Activity::onExit() { LOG_DBG("ACT", "Exiting activity: %s", name.c_str());
|
||||
|
||||
void Activity::requestUpdate(bool immediate) { activityManager.requestUpdate(immediate); }
|
||||
|
||||
void Activity::requestUpdateAndWait() {
|
||||
// FIXME @ngxson : properly implement this using freeRTOS notification
|
||||
activityManager.requestUpdate(true);
|
||||
delay(100);
|
||||
}
|
||||
void Activity::requestUpdateAndWait() { activityManager.requestUpdateAndWait(); }
|
||||
|
||||
void Activity::onGoHome() { activityManager.goHome(); }
|
||||
|
||||
|
||||
Reference in New Issue
Block a user