eric/Crosspoint
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Eliminated relative path includes (#1961)

Browse Source 
## Summary

Relative includes can hide inappropriate dependency relationships. In
this case, I found that lib/KOReaderSync/KOReaderCredentialStore.cpp was
dependent on src/JsonSettingsIO.h -- a lib -> app dependency, the
opposite direction dependencies should flow in this project.

This change replaces all relative includes with root-relative includes,
and corrects the KOReaderCredentialStore dependency by moving its JSON
settings serialization local to the KOReaderSync library.

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? _**PARTIALLY**_
This commit is contained in:
Zach Nelson
2026-05-13 08:26:30 -05:00
committed by GitHub
parent bc57e5d64b
commit 6f7f4c592a
40 changed files with 107 additions and 101 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/Epub/Epub/hyphenation/generated/hyph-de.trie.h
+1 -1
View File
@@ -3,7 +3,7 @@
#include <cstddef>
#include <cstdint>
#include "../SerializedHyphenationTrie.h"
#include "Epub/hyphenation/SerializedHyphenationTrie.h"
// Auto-generated by generate_hyphenation_trie.py. Do not edit manually.
alignas(4) constexpr uint8_t de_trie_data[] = {
lib/Epub/Epub/hyphenation/generated/hyph-en.trie.h
+1 -1
View File
@@ -3,7 +3,7 @@
#include <cstddef>
#include <cstdint>
#include "../SerializedHyphenationTrie.h"
#include "Epub/hyphenation/SerializedHyphenationTrie.h"
// Auto-generated by generate_hyphenation_trie.py. Do not edit manually.
alignas(4) constexpr uint8_t en_trie_data[] = {
lib/Epub/Epub/hyphenation/generated/hyph-es.trie.h
+1 -1
View File
@@ -3,7 +3,7 @@
#include <cstddef>
#include <cstdint>
#include "../SerializedHyphenationTrie.h"
#include "Epub/hyphenation/SerializedHyphenationTrie.h"
// Auto-generated by generate_hyphenation_trie.py. Do not edit manually.
alignas(4) constexpr uint8_t es_trie_data[] = {
lib/Epub/Epub/hyphenation/generated/hyph-fr.trie.h
+1 -1
View File
@@ -3,7 +3,7 @@
#include <cstddef>
#include <cstdint>
#include "../SerializedHyphenationTrie.h"
#include "Epub/hyphenation/SerializedHyphenationTrie.h"
// Auto-generated by generate_hyphenation_trie.py. Do not edit manually.
alignas(4) constexpr uint8_t fr_trie_data[] = {
lib/Epub/Epub/hyphenation/generated/hyph-it.trie.h
+1 -1
View File
@@ -3,7 +3,7 @@
#include <cstddef>
#include <cstdint>
#include "../SerializedHyphenationTrie.h"
#include "Epub/hyphenation/SerializedHyphenationTrie.h"
// Auto-generated by generate_hyphenation_trie.py. Do not edit manually.
alignas(4) constexpr uint8_t it_trie_data[] = {
lib/Epub/Epub/hyphenation/generated/hyph-ru.trie.h
+1 -1
View File
@@ -3,7 +3,7 @@
#include <cstddef>
#include <cstdint>
#include "../SerializedHyphenationTrie.h"
#include "Epub/hyphenation/SerializedHyphenationTrie.h"
// Auto-generated by generate_hyphenation_trie.py. Do not edit manually.
alignas(4) constexpr uint8_t ru_trie_data[] = {
lib/Epub/Epub/hyphenation/generated/hyph-uk.trie.h
+1 -1
View File
@@ -3,7 +3,7 @@
#include <cstddef>
#include <cstdint>
#include "../SerializedHyphenationTrie.h"
#include "Epub/hyphenation/SerializedHyphenationTrie.h"
// Auto-generated by generate_hyphenation_trie.py. Do not edit manually.
alignas(4) constexpr uint8_t uk_trie_data[] = {