Introduce common helper functions

src/activities/settings/SettingInfo.h

@@ -0,0 +1,190 @@
+#pragma once
+#include <I18n.h>
+
+#include <functional>
+#include <string>
+#include <vector>
+
+#include "CrossPointSettings.h"
+
+enum class SettingType { TOGGLE, ENUM, ACTION, VALUE, STRING };
+
+enum class SettingAction {
+  None,
+  RemapFrontButtons,
+  CustomiseStatusBar,
+  ClockSettings,
+  KOReaderSync,
+  OPDSBrowser,
+  Network,
+  ClearCache,
+  CheckForUpdates,
+  Language,
+  SystemInfo,
+  DetectTimezone,
+  SyncTime,
+  Weather,
+  Submenu,
+};
+
+struct SettingInfo {
+  StrId nameId;
+  SettingType type;
+  uint8_t CrossPointSettings::* valuePtr = nullptr;
+  std::vector<StrId> enumValues;
+  SettingAction action = SettingAction::None;
+
+  struct ValueRange {
+    uint8_t min;
+    uint8_t max;
+    uint8_t step;
+  };
+  ValueRange valueRange = {};
+
+  const char* key = nullptr;             // JSON API key (nullptr for ACTION types)
+  StrId category = StrId::STR_NONE_OPT;  // Category for web UI grouping
+  bool obfuscated = false;               // Save/load via base64 obfuscation (passwords)
+
+  // Direct char[] string fields (for settings stored in CrossPointSettings)
+  size_t stringOffset = 0;
+  size_t stringMaxLen = 0;
+
+  // Dynamic accessors (for settings stored outside CrossPointSettings, e.g. KOReaderCredentialStore)
+  std::function<uint8_t()> valueGetter;
+  std::function<void(uint8_t)> valueSetter;
+  std::function<std::string()> stringGetter;
+  std::function<void(const std::string&)> stringSetter;
+
+  SettingInfo& withObfuscated() {
+    obfuscated = true;
+    return *this;
+  }
+
+  static SettingInfo Toggle(StrId nameId, uint8_t CrossPointSettings::* ptr, const char* key = nullptr,
+                            StrId category = StrId::STR_NONE_OPT) {
+    SettingInfo s;
+    s.nameId = nameId;
+    s.type = SettingType::TOGGLE;
+    s.valuePtr = ptr;
+    s.key = key;
+    s.category = category;
+    return s;
+  }
+
+  static SettingInfo Enum(StrId nameId, uint8_t CrossPointSettings::* ptr, std::vector<StrId> values,
+                          const char* key = nullptr, StrId category = StrId::STR_NONE_OPT) {
+    SettingInfo s;
+    s.nameId = nameId;
+    s.type = SettingType::ENUM;
+    s.valuePtr = ptr;
+    s.enumValues = std::move(values);
+    s.key = key;
+    s.category = category;
+    return s;
+  }
+
+  static SettingInfo Action(StrId nameId, SettingAction action) {
+    SettingInfo s;
+    s.nameId = nameId;
+    s.type = SettingType::ACTION;
+    s.action = action;
+    return s;
+  }
+
+  static SettingInfo Value(StrId nameId, uint8_t CrossPointSettings::* ptr, const ValueRange valueRange,
+                           const char* key = nullptr, StrId category = StrId::STR_NONE_OPT) {
+    SettingInfo s;
+    s.nameId = nameId;
+    s.type = SettingType::VALUE;
+    s.valuePtr = ptr;
+    s.valueRange = valueRange;
+    s.key = key;
+    s.category = category;
+    return s;
+  }
+
+  static SettingInfo String(StrId nameId, char* ptr, size_t maxLen, const char* key = nullptr,
+                            StrId category = StrId::STR_NONE_OPT) {
+    SettingInfo s;
+    s.nameId = nameId;
+    s.type = SettingType::STRING;
+    s.stringOffset = (size_t)ptr - (size_t)&SETTINGS;
+    s.stringMaxLen = maxLen;
+    s.key = key;
+    s.category = category;
+    return s;
+  }
+
+  static SettingInfo DynamicEnum(StrId nameId, std::vector<StrId> values, std::function<uint8_t()> getter,
+                                 std::function<void(uint8_t)> setter, const char* key = nullptr,
+                                 StrId category = StrId::STR_NONE_OPT) {
+    SettingInfo s;
+    s.nameId = nameId;
+    s.type = SettingType::ENUM;
+    s.enumValues = std::move(values);
+    s.valueGetter = std::move(getter);
+    s.valueSetter = std::move(setter);
+    s.key = key;
+    s.category = category;
+    return s;
+  }
+
+  static SettingInfo DynamicString(StrId nameId, std::function<std::string()> getter,
+                                   std::function<void(const std::string&)> setter, const char* key = nullptr,
+                                   StrId category = StrId::STR_NONE_OPT) {
+    SettingInfo s;
+    s.nameId = nameId;
+    s.type = SettingType::STRING;
+    s.stringGetter = std::move(getter);
+    s.stringSetter = std::move(setter);
+    s.key = key;
+    s.category = category;
+    return s;
+  }
+
+  static SettingInfo Separator(StrId nameId) {
+    SettingInfo s;
+    s.nameId = nameId;
+    s.type = SettingType::ACTION;
+    s.isSeparator = true;
+    return s;
+  }
+
+  bool isSeparator = false;
+  StrId subcategory = StrId::STR_NONE_OPT;  // Triggers a separator row on first use and on change
+  StrId submenu = StrId::STR_NONE_OPT;      // Routes item into a submenu; hidden from main list
+
+  // Inserts a separator row in the parent tab when this item's subcategory first appears or changes.
+  SettingInfo& withSubcategory(StrId sub) {
+    subcategory = sub;
+    return *this;
+  }
+
+  // Hides this item from the parent tab and places it inside a SettingsSubmenuActivity instead.
+  // All items sharing the same submenu StrId are grouped under one placeholder entry.
+  SettingInfo& withSubmenu(StrId sub) {
+    submenu = sub;
+    return *this;
+  }
+
+  // For internal use by SettingsActivity: placeholder entry that launches the submenu.
+  static SettingInfo SubmenuEntry(StrId titleId) {
+    SettingInfo s;
+    s.nameId = titleId;
+    s.type = SettingType::ACTION;
+    s.action = SettingAction::Submenu;
+    return s;
+  }
+
+  // Returns the localised title; separators are decorated automatically.
+  [[nodiscard]] std::string getTitle() const;
+
+  // Returns the current display value string (ON/OFF for toggles, enum label, numeric value, >>).
+  [[nodiscard]] std::string getDisplayValue() const;
+
+  // Toggles/cycles the underlying value for TOGGLE, ENUM, and VALUE types.
+  // Does nothing for ACTION and STRING types (callers handle those separately).
+  // Marked const because it mutates the external SETTINGS global (via valuePtr),
+  // not the SettingInfo itself.
+  void toggleValue() const;
+};