eric/Crosspoint
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Nitpick comments

Browse Source
This commit is contained in:
jpirnay
2026-02-28 16:51:04 +01:00
parent e547f70cae
commit 3eadc1e923
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/Epub/Epub/Section.cpp
+6 -1
View File
@@ -122,6 +122,11 @@ bool Section::loadSectionFile(const int fontId, const float lineCompression, con
} }
for (uint32_t& pos : lut) { for (uint32_t& pos : lut) {
serialization::readPod(file, pos); serialization::readPod(file, pos);
if (pos < HEADER_SIZE || pos >= lutOffset) {
LOG_ERR("SCT", "Deserialization failed: LUT entry %u out of range [%u, %u)", pos, HEADER_SIZE, lutOffset);
clearCache();
return false;
}
} }
// File is intentionally left open; subsequent loadPageFromSectionFile() calls // File is intentionally left open; subsequent loadPageFromSectionFile() calls
// seek within this handle instead of re-opening the file each time. // seek within this handle instead of re-opening the file each time.
@@ -268,11 +273,11 @@ bool Section::createSectionFile(const int fontId, const float lineCompression, c
// Cache the LUT in memory and open the file for reading so that // Cache the LUT in memory and open the file for reading so that
// subsequent loadPageFromSectionFile() calls can seek directly without re-opening. // subsequent loadPageFromSectionFile() calls can seek directly without re-opening.
this->lut = std::move(lut);
if (!Storage.openFileForRead("SCT", filePath, file)) { if (!Storage.openFileForRead("SCT", filePath, file)) {
LOG_ERR("SCT", "Failed to open section file for reading after creation"); LOG_ERR("SCT", "Failed to open section file for reading after creation");
return false; return false;
} }
this->lut = std::move(lut);
return true; return true;
} }