From 398a25c4177cc7c6b469593264c13d06758d222f Mon Sep 17 00:00:00 2001
From: jpirnay <jens@pirnay.com>
Date: Mon, 13 Apr 2026 11:38:52 +0200
Subject: [PATCH] Review comment

---
 lib/KOReaderSync/KOReaderSyncClient.cpp | 15 ++++++++++++---
 lib/KOReaderSync/KOReaderSyncClient.h   |  3 ++-
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/lib/KOReaderSync/KOReaderSyncClient.cpp b/lib/KOReaderSync/KOReaderSyncClient.cpp
index b537d2e5..e0c81f1d 100644
--- a/lib/KOReaderSync/KOReaderSyncClient.cpp
+++ b/lib/KOReaderSync/KOReaderSyncClient.cpp
@@ -383,14 +383,14 @@ KOReaderSyncClient::Error KOReaderSyncClient::authenticate() {
     // Skip leading whitespace before checking for '{' so servers that emit
     // a BOM or indent their JSON don't get incorrectly rejected.
     if (!activeBuf->data) {
-      return SERVER_ERROR;
+      return INVALID_RESPONSE;
     }
     const char* p = activeBuf->data;
     while (*p == ' ' || *p == '\t' || *p == '\r' || *p == '\n') {
       p++;
     }
     if (*p != '{') {
-      return SERVER_ERROR;
+      return INVALID_RESPONSE;
     }
     return OK;
   }
@@ -585,7 +585,7 @@ KOReaderSyncClient::Error KOReaderSyncClient::updateProgress(const KOReaderProgr
         p++;
       }
       if (*p != '\0' && *p != '{') {
-        return SERVER_ERROR;
+        return INVALID_RESPONSE;
       }
     }
     return OK;
@@ -622,6 +622,13 @@ const char* KOReaderSyncClient::lastFailureDetail() {
     }
     return g_failureDetailBuf;
   }
+  // Invalid-response case: HTTP 200/202 but body was not JSON (e.g. captive portal HTML).
+  // On real success callers never reach lastFailureDetail(), so a 2xx here means INVALID_RESPONSE.
+  if ((lastHttpCode == 200 || lastHttpCode == 202) && lastEspError == ESP_OK) {
+    snprintf(g_failureDetailBuf, sizeof(g_failureDetailBuf),
+             "%s: expected JSON but received HTML (captive portal or proxy?)", lastOperation);
+    return g_failureDetailBuf;
+  }
   // Server case: got an HTTP status the client didn't recognize as success.
   if (lastHttpCode != 0) {
     snprintf(g_failureDetailBuf, sizeof(g_failureDetailBuf), "%s: HTTP %d", lastOperation, lastHttpCode);
@@ -654,6 +661,8 @@ const char* KOReaderSyncClient::errorString(Error error) {
       return "Registration is disabled on this server";
     case REDIRECT_ERROR:
       return "Server redirected (check server URL)";
+    case INVALID_RESPONSE:
+      return "Unexpected response (check server URL)";
     default:
       return "Unknown error";
   }
diff --git a/lib/KOReaderSync/KOReaderSyncClient.h b/lib/KOReaderSync/KOReaderSyncClient.h
index eef7f875..8ffa0203 100644
--- a/lib/KOReaderSync/KOReaderSyncClient.h
+++ b/lib/KOReaderSync/KOReaderSyncClient.h
@@ -40,7 +40,8 @@ class KOReaderSyncClient {
     NOT_FOUND,
     USER_EXISTS,
     REGISTRATION_DISABLED,
-    REDIRECT_ERROR
+    REDIRECT_ERROR,
+    INVALID_RESPONSE
   };
 
   /**