eric/Crosspoint
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Address nitpick review comments

Browse Source
This commit is contained in:
spfenwick
2026-05-02 20:23:29 +12:00
parent f07724dab4
commit 3835236961
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/Epub/Epub/ParsedText.cpp
+2 -8
View File
@@ -383,11 +383,11 @@ void ParsedText::layoutAndExtractLines(
words.shrink_to_fit(); words.shrink_to_fit();
wordStyles.shrink_to_fit(); wordStyles.shrink_to_fit();
wordContinues.shrink_to_fit(); wordContinues.shrink_to_fit();
isContinuation_ = !includeLastLine;
// All remaining words were already transformed before the flush; reset the // All remaining words were already transformed before the flush; reset the
// watermark so that words appended by addWord() are processed next time. // watermark so that words appended by addWord() are processed next time.
bionicTransformedUpTo_ = words.size(); bionicTransformedUpTo_ = words.size();
} }
isContinuation_ = !includeLastLine;
} }
std::vector<uint16_t> ParsedText::calculateWordWidths(const GfxRenderer& renderer, const int fontId) { std::vector<uint16_t> ParsedText::calculateWordWidths(const GfxRenderer& renderer, const int fontId) {
@@ -610,7 +610,6 @@ void ParsedText::applyBionicReadingTransform() {
std::string source = std::move(words[i]); std::string source = std::move(words[i]);
const auto originalStyle = wordStyles[i]; const auto originalStyle = wordStyles[i];
const bool originalAttachToPrevious = wordContinues[i]; const bool originalAttachToPrevious = wordContinues[i];
const char* raw = source.c_str();
const auto spans = tokenizeBionicWord(source); const auto spans = tokenizeBionicWord(source);
if (spans.empty()) { if (spans.empty()) {
@@ -621,12 +620,7 @@ void ParsedText::applyBionicReadingTransform() {
for (size_t spanIndex = 0; spanIndex < spans.size(); ++spanIndex) { for (size_t spanIndex = 0; spanIndex < spans.size(); ++spanIndex) {
const TokenSpan span = spans[spanIndex]; const TokenSpan span = spans[spanIndex];
const size_t spanLength = span.end - span.start; const size_t spanLength = span.end - span.start;
std::string token; std::string token = source.substr(span.start, spanLength);
if (spans.size() == 1 && spanIndex == 0) {
token = std::move(source);
} else {
token.assign(raw + span.start, spanLength);
}
if (span.isWord) { if (span.isWord) {
const unsigned char* ptr = reinterpret_cast<const unsigned char*>(token.c_str()); const unsigned char* ptr = reinterpret_cast<const unsigned char*>(token.c_str());