eric/Crosspoint
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Use std::size instead of sizeof/sizeof (#1819)

Browse Source 
## Summary

Simplify code calculating compile-time array sizes with
`sizeof(array)/sizeof(element)` to use `std::size`.

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? _**PARTIALLY**_
This commit is contained in:
Zach Nelson
2026-05-04 12:41:27 -05:00
committed by GitHub
parent e026bcb9dc
commit 333286acfc
4 changed files with 42 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/network/WebDAVHandler.cpp
+5 -6
View File
@@ -7,8 +7,7 @@
#include <esp_task_wdt.h>
namespace {
const char* HIDDEN_ITEMS[] = {"System Volume Information", "XTCache"};
constexpr size_t HIDDEN_ITEMS_COUNT = sizeof(HIDDEN_ITEMS) / sizeof(HIDDEN_ITEMS[0]);
constexpr const char* HIDDEN_ITEMS[] = {"System Volume Information", "XTCache"};
// RFC 1123 date format helper: "Sun, 06 Nov 1994 08:49:37 GMT"
// ESP32 doesn't have real-time clock set by default, so we use a fixed epoch date
@@ -230,8 +229,8 @@ void WebDAVHandler::handlePropfind(WebServer& s) {
// Skip hidden/protected items
bool shouldHide = fileName.startsWith(".");
if (!shouldHide) {
for (size_t i = 0; i < HIDDEN_ITEMS_COUNT; i++) {
if (fileName.equals(HIDDEN_ITEMS[i])) {
for (const auto* item : HIDDEN_ITEMS) {
if (fileName.equals(item)) {
shouldHide = true;
break;
}
@@ -774,8 +773,8 @@ bool WebDAVHandler::isProtectedPath(const String& path) const {
if (segment.startsWith(".")) return true;
for (size_t i = 0; i < HIDDEN_ITEMS_COUNT; i++) {
if (segment.equals(HIDDEN_ITEMS[i])) return true;
for (const auto* item : HIDDEN_ITEMS) {
if (segment.equals(item)) return true;
}
start = end + 1;