diff --git a/lib/Epub/Epub/parsers/ContentOpfParser.cpp b/lib/Epub/Epub/parsers/ContentOpfParser.cpp index 85bc7a68..20e33784 100644 --- a/lib/Epub/Epub/parsers/ContentOpfParser.cpp +++ b/lib/Epub/Epub/parsers/ContentOpfParser.cpp @@ -150,7 +150,6 @@ void XMLCALL ContentOpfParser::startElement(void* userData, const XML_Char* name if (self->state == IN_PACKAGE && (strcmp(name, "guide") == 0 || strcmp(name, "opf:guide") == 0)) { self->state = IN_GUIDE; - // TODO Remove print LOG_DBG("COF", "Entering guide state."); if (!Storage.openFileForRead("COF", self->cachePath + itemCacheFile, self->tempItemStore)) { LOG_ERR("COF", "Couldn't open temp items file for reading. This is probably going to be a fatal error."); diff --git a/src/MappedInputManager.cpp b/src/MappedInputManager.cpp index b8f76abd..594f19f2 100644 --- a/src/MappedInputManager.cpp +++ b/src/MappedInputManager.cpp @@ -3,7 +3,6 @@ #include #include -#include #include #include "CrossPointSettings.h" diff --git a/src/activities/Activity.h b/src/activities/Activity.h index 070eb4fd..d9badde0 100644 --- a/src/activities/Activity.h +++ b/src/activities/Activity.h @@ -56,8 +56,7 @@ class Activity { // Finish this activity and return to the previous one on the stack (if any) void finish(); - // Convenience method to facilitate API transition to ActivityManager - // TODO: remove this in near future + // Convenience method to facilitate API transition to ActivityManager. void onGoHome(HomeMenuItem item = HomeMenuItem::NONE); void onSelectBook(const std::string& path); }; diff --git a/src/activities/browser/OpdsBookBrowserActivity.cpp b/src/activities/browser/OpdsBookBrowserActivity.cpp index 8333a4f2..95564b5e 100644 --- a/src/activities/browser/OpdsBookBrowserActivity.cpp +++ b/src/activities/browser/OpdsBookBrowserActivity.cpp @@ -33,7 +33,6 @@ void OpdsBookBrowserActivity::onEnter() { currentPath = ""; selectorIndex = 0; consumeConfirm = false; - consumeBack = false; errorMessage.clear(); statusMessage = tr(STR_CHECKING_WIFI); requestUpdate(); @@ -62,10 +61,6 @@ void OpdsBookBrowserActivity::loop() { consumeConfirm = false; return; } - if (consumeBack && mappedInput.wasReleased(MappedInputManager::Button::Back)) { - consumeBack = false; - return; - } if (state == BrowserState::ERROR) { if (mappedInput.wasReleased(MappedInputManager::Button::Confirm)) { diff --git a/src/activities/browser/OpdsBookBrowserActivity.h b/src/activities/browser/OpdsBookBrowserActivity.h index bf8642b0..a01bf7ba 100644 --- a/src/activities/browser/OpdsBookBrowserActivity.h +++ b/src/activities/browser/OpdsBookBrowserActivity.h @@ -33,7 +33,6 @@ class OpdsBookBrowserActivity final : public Activity { std::string currentPath; std::string searchTemplate; bool consumeConfirm = false; - bool consumeBack = false; // Added missing member int selectorIndex = 0; std::string errorMessage; std::string statusMessage; diff --git a/src/activities/network/NetworkModeSelectionActivity.cpp b/src/activities/network/NetworkModeSelectionActivity.cpp index bf70ad06..5aabd9d9 100644 --- a/src/activities/network/NetworkModeSelectionActivity.cpp +++ b/src/activities/network/NetworkModeSelectionActivity.cpp @@ -51,7 +51,6 @@ void NetworkModeSelectionActivity::loop() { return; } - // Handle navigation buttonNavigator.onNext([this] { selectedIndex = ButtonNavigator::nextIndex(selectedIndex, MENU_ITEM_COUNT); requestUpdate(); @@ -86,7 +85,6 @@ void NetworkModeSelectionActivity::render(RenderLock&&) { [](int index) { return std::string(I18N.get(menuItems[index])); }, [](int index) { return std::string(I18N.get(menuDescs[index])); }, [](int index) { return menuIcons[index]; }); - // Draw help text at bottom const auto labels = mappedInput.mapLabels(tr(STR_BACK), tr(STR_SELECT), tr(STR_DIR_UP), tr(STR_DIR_DOWN)); GUI.drawButtonHints(renderer, labels.btn1, labels.btn2, labels.btn3, labels.btn4); diff --git a/src/activities/network/WifiSelectionActivity.cpp b/src/activities/network/WifiSelectionActivity.cpp index b1dd92db..3295afcc 100644 --- a/src/activities/network/WifiSelectionActivity.cpp +++ b/src/activities/network/WifiSelectionActivity.cpp @@ -463,7 +463,6 @@ void WifiSelectionActivity::loop() { } } - // Handle navigation buttonNavigator.onNext([this] { selectedNetworkIndex = ButtonNavigator::nextIndex(selectedNetworkIndex, networks.size()); requestUpdate(); diff --git a/src/activities/reader/EpubReaderActivity.cpp b/src/activities/reader/EpubReaderActivity.cpp index 31392e30..b3cca7ec 100644 --- a/src/activities/reader/EpubReaderActivity.cpp +++ b/src/activities/reader/EpubReaderActivity.cpp @@ -723,7 +723,6 @@ void EpubReaderActivity::pageTurn(bool isForwardTurn) { requestUpdate(); } -// TODO: Failure handling void EpubReaderActivity::render(RenderLock&& lock) { if (!epub) { return; diff --git a/src/activities/reader/EpubReaderFootnotesActivity.cpp b/src/activities/reader/EpubReaderFootnotesActivity.cpp index a6d4ea59..0821cbb2 100644 --- a/src/activities/reader/EpubReaderFootnotesActivity.cpp +++ b/src/activities/reader/EpubReaderFootnotesActivity.cpp @@ -20,7 +20,11 @@ void EpubReaderFootnotesActivity::onEnter() { void EpubReaderFootnotesActivity::onExit() { Activity::onExit(); } void EpubReaderFootnotesActivity::loop() { - const int visibleCount = std::max(1, renderer.getScreenHeight() / 36); + constexpr int lineHeight = 36; + const auto orientation = renderer.getOrientation(); + const bool isPortraitInverted = orientation == GfxRenderer::Orientation::PortraitInverted; + const int contentY = isPortraitInverted ? 50 : 0; + const int visibleCount = std::max(1, (renderer.getScreenHeight() - contentY) / lineHeight); if (mappedInput.wasListScroll(selectedIndex, static_cast(footnotes.size()), visibleCount)) { requestUpdate(); return; diff --git a/src/activities/reader/EpubReaderMenuActivity.cpp b/src/activities/reader/EpubReaderMenuActivity.cpp index 0c952238..4dc1dfdf 100644 --- a/src/activities/reader/EpubReaderMenuActivity.cpp +++ b/src/activities/reader/EpubReaderMenuActivity.cpp @@ -46,7 +46,6 @@ void EpubReaderMenuActivity::onEnter() { void EpubReaderMenuActivity::onExit() { Activity::onExit(); } void EpubReaderMenuActivity::loop() { - // Handle navigation buttonNavigator.onNext([this] { selectedIndex = ButtonNavigator::nextIndex(selectedIndex, static_cast(menuItems.size())); requestUpdate(); diff --git a/src/activities/settings/KOReaderSettingsActivity.cpp b/src/activities/settings/KOReaderSettingsActivity.cpp index 9aab7d08..aa53702d 100644 --- a/src/activities/settings/KOReaderSettingsActivity.cpp +++ b/src/activities/settings/KOReaderSettingsActivity.cpp @@ -52,7 +52,6 @@ void KOReaderSettingsActivity::loop() { return; } - // Handle navigation buttonNavigator.onNext([this] { selectedIndex = (selectedIndex + 1) % MENU_ITEMS; requestUpdate(); @@ -156,7 +155,6 @@ void KOReaderSettingsActivity::render(RenderLock&&) { }, true); - // Draw help text at bottom const auto labels = mappedInput.mapLabels(tr(STR_BACK), tr(STR_SELECT), tr(STR_DIR_UP), tr(STR_DIR_DOWN)); GUI.drawButtonHints(renderer, labels.btn1, labels.btn2, labels.btn3, labels.btn4); diff --git a/src/activities/settings/LanguageSelectActivity.cpp b/src/activities/settings/LanguageSelectActivity.cpp index d60a3a20..306987ca 100644 --- a/src/activities/settings/LanguageSelectActivity.cpp +++ b/src/activities/settings/LanguageSelectActivity.cpp @@ -57,7 +57,6 @@ void LanguageSelectActivity::loop() { return; } - // Handle navigation buttonNavigator.onNextRelease([this] { selectedIndex = ButtonNavigator::nextIndex(static_cast(selectedIndex), totalItems); requestUpdate(); diff --git a/src/activities/settings/SettingsActivity.cpp b/src/activities/settings/SettingsActivity.cpp index 80302410..9cd94d49 100644 --- a/src/activities/settings/SettingsActivity.cpp +++ b/src/activities/settings/SettingsActivity.cpp @@ -189,7 +189,6 @@ void SettingsActivity::loop() { return; } - // Handle navigation buttonNavigator.onNextRelease([this] { selectedSettingIndex = ButtonNavigator::nextIndex(selectedSettingIndex, settingsCount + 1); requestUpdate(); @@ -429,7 +428,6 @@ void SettingsActivity::render(RenderLock&&) { }, true); - // Draw help text const auto confirmLabel = (selectedSettingIndex == 0) ? I18N.get(categoryNames[(selectedCategoryIndex + 1) % categoryCount]) diff --git a/src/activities/settings/StatusBarSettingsActivity.cpp b/src/activities/settings/StatusBarSettingsActivity.cpp index ce456a44..763f1fee 100644 --- a/src/activities/settings/StatusBarSettingsActivity.cpp +++ b/src/activities/settings/StatusBarSettingsActivity.cpp @@ -150,7 +150,6 @@ void StatusBarSettingsActivity::loop() { return; } - // Handle navigation buttonNavigator.onNextRelease([this] { selectedIndex = ButtonNavigator::nextIndex(selectedIndex, visibleItemCount); requestUpdate(); diff --git a/src/activities/util/BmpViewerActivity.cpp b/src/activities/util/BmpViewerActivity.cpp index f36d3425..5b7694d0 100644 --- a/src/activities/util/BmpViewerActivity.cpp +++ b/src/activities/util/BmpViewerActivity.cpp @@ -107,13 +107,9 @@ void BmpViewerActivity::onEnter() { GUI.fillPopupProgress(renderer, popupRect, 50); renderer.clearScreen(); - // Assuming drawBitmap defaults to 0,0 crop if omitted, or pass explicitly: drawBitmap(bitmap, x, y, pageWidth, - // pageHeight, 0, 0) renderer.drawBitmap(bitmap, x, y, pageWidth, pageHeight, 0, 0); - // Draw UI hints on the base layer GUI.drawButtonHints(renderer, labels.btn1, labels.btn2, labels.btn3, labels.btn4); - // Single pass for non-grayscale images renderer.displayBuffer(HalDisplay::FAST_REFRESH);